IntelliJ Themes: fixed unselected CheckBox and RadioButton icon colors for themes "Atom One Light", "Cyan Light", "GitHub", "Light Owl", "Material Lighter" and "Solarized Light"

This commit is contained in:
Karl Tauber
2023-08-02 14:25:15 +02:00
parent 7e8fa58bd7
commit 170c22c5ed
3 changed files with 6 additions and 11 deletions

View File

@@ -31,6 +31,9 @@ FlatLaf Change Log
not visible. (issue #686) not visible. (issue #686)
- "Monocai" theme: Fixed unreadable text color of default buttons. (issue - "Monocai" theme: Fixed unreadable text color of default buttons. (issue
#693) #693)
- CheckBox and RadioButton: Fixed unselected icon colors for themes "Atom One
Light", "Cyan Light", "GitHub", "Light Owl", "Material Lighter" and
"Solarized Light".
- TabbedPane: Fixed focused tab background color for themes "Arc *", "Material - TabbedPane: Fixed focused tab background color for themes "Arc *", "Material
Design Dark", "Monocai", "One Dark", "Spacegray" and "Xcode-Dark". (issue Design Dark", "Monocai", "One Dark", "Spacegray" and "Xcode-Dark". (issue
#697) #697)

View File

@@ -482,7 +482,7 @@ public class IntelliJTheme
/** /**
* Because IDEA uses SVGs for check boxes and radio buttons, the colors for * Because IDEA uses SVGs for check boxes and radio buttons, the colors for
* this two components are specified in "icons > ColorPalette". * these two components are specified in "icons > ColorPalette".
* FlatLaf uses vector icons and expects colors for the two components in UI defaults. * FlatLaf uses vector icons and expects colors for the two components in UI defaults.
*/ */
private void applyCheckBoxColors( UIDefaults defaults ) { private void applyCheckBoxColors( UIDefaults defaults ) {
@@ -502,16 +502,6 @@ public class IntelliJTheme
if( !key.startsWith( "Checkbox." ) || !(value instanceof String) ) if( !key.startsWith( "Checkbox." ) || !(value instanceof String) )
continue; continue;
if( key.equals( "Checkbox.Background.Default" ) ||
key.equals( "Checkbox.Foreground.Selected" ) )
{
// This two keys do not work correctly in IDEA because they
// map SVG color "#ffffff" to another color, but checkBox.svg and
// radio.svg (in package com.intellij.ide.ui.laf.icons.intellij)
// use "#fff". So use white to get same appearance as in IDEA.
value = "#ffffff";
}
String key2 = checkboxDuplicateColors.get( key ); String key2 = checkboxDuplicateColors.get( key );
if( dark ) if( dark )

View File

@@ -196,6 +196,8 @@ ToggleButton.endBackground = $ToggleButton.background
toolbar.selectedBackground: #fff toolbar.selectedBackground: #fff
[High_contrast][style]ToggleButton.inTextField = $[High_contrast][style]Button.inTextField [High_contrast][style]ToggleButton.inTextField = $[High_contrast][style]Button.inTextField
[Light_Flat]CheckBox.icon[filled].background = #fff
[Light_Flat]CheckBox.icon[filled].checkmarkColor = #fff
[Light_Flat]Component.accentColor = lazy(TabbedPane.underlineColor) [Light_Flat]Component.accentColor = lazy(TabbedPane.underlineColor)
[Light_Flat]TableHeader.background = #E5E5E9 [Light_Flat]TableHeader.background = #E5E5E9