tests: update httpd test to use testify

config/config_test.go

@@ -24,7 +24,7 @@ const (
 func TestLoadConfigTest(t *testing.T) {
 	configDir := ".."
 	err := config.LoadConfig(configDir, configName)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	assert.NotEqual(t, httpd.Conf{}, config.GetHTTPConfig())
 	assert.NotEqual(t, dataprovider.Config{}, config.GetProviderConf())
 	assert.NotEqual(t, sftpd.Configuration{}, config.GetSFTPDConfig())
@@ -34,15 +34,15 @@ func TestLoadConfigTest(t *testing.T) {
 	err = config.LoadConfig(configDir, tempConfigName)
 	assert.NotNil(t, err)
 	err = ioutil.WriteFile(configFilePath, []byte("{invalid json}"), 0666)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	err = config.LoadConfig(configDir, tempConfigName)
 	assert.NotNil(t, err)
 	err = ioutil.WriteFile(configFilePath, []byte("{\"sftpd\": {\"bind_port\": \"a\"}}"), 0666)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	err = config.LoadConfig(configDir, tempConfigName)
 	assert.NotNil(t, err)
 	err = os.Remove(configFilePath)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 }
 
 func TestEmptyBanner(t *testing.T) {
@@ -50,20 +50,20 @@ func TestEmptyBanner(t *testing.T) {
 	confName := tempConfigName + ".json"
 	configFilePath := filepath.Join(configDir, confName)
 	err := config.LoadConfig(configDir, configName)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	sftpdConf := config.GetSFTPDConfig()
 	sftpdConf.Banner = " "
 	c := make(map[string]sftpd.Configuration)
 	c["sftpd"] = sftpdConf
 	jsonConf, _ := json.Marshal(c)
 	err = ioutil.WriteFile(configFilePath, jsonConf, 0666)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	err = config.LoadConfig(configDir, tempConfigName)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	sftpdConf = config.GetSFTPDConfig()
 	assert.NotEmpty(t, strings.TrimSpace(sftpdConf.Banner))
 	err = os.Remove(configFilePath)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 }
 
 func TestInvalidUploadMode(t *testing.T) {
@@ -71,19 +71,19 @@ func TestInvalidUploadMode(t *testing.T) {
 	confName := tempConfigName + ".json"
 	configFilePath := filepath.Join(configDir, confName)
 	err := config.LoadConfig(configDir, configName)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	sftpdConf := config.GetSFTPDConfig()
 	sftpdConf.UploadMode = 10
 	c := make(map[string]sftpd.Configuration)
 	c["sftpd"] = sftpdConf
 	jsonConf, err := json.Marshal(c)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	err = ioutil.WriteFile(configFilePath, jsonConf, 0666)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	err = config.LoadConfig(configDir, tempConfigName)
 	assert.NotNil(t, err)
 	err = os.Remove(configFilePath)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 }
 
 func TestInvalidExternalAuthScope(t *testing.T) {
@@ -91,19 +91,19 @@ func TestInvalidExternalAuthScope(t *testing.T) {
 	confName := tempConfigName + ".json"
 	configFilePath := filepath.Join(configDir, confName)
 	err := config.LoadConfig(configDir, configName)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	providerConf := config.GetProviderConf()
 	providerConf.ExternalAuthScope = 10
 	c := make(map[string]dataprovider.Config)
 	c["data_provider"] = providerConf
 	jsonConf, err := json.Marshal(c)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	err = ioutil.WriteFile(configFilePath, jsonConf, 0666)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	err = config.LoadConfig(configDir, tempConfigName)
 	assert.NotNil(t, err)
 	err = os.Remove(configFilePath)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 }
 
 func TestInvalidCredentialsPath(t *testing.T) {
@@ -111,19 +111,19 @@ func TestInvalidCredentialsPath(t *testing.T) {
 	confName := tempConfigName + ".json"
 	configFilePath := filepath.Join(configDir, confName)
 	err := config.LoadConfig(configDir, configName)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	providerConf := config.GetProviderConf()
 	providerConf.CredentialsPath = ""
 	c := make(map[string]dataprovider.Config)
 	c["data_provider"] = providerConf
 	jsonConf, err := json.Marshal(c)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	err = ioutil.WriteFile(configFilePath, jsonConf, 0666)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	err = config.LoadConfig(configDir, tempConfigName)
 	assert.NotNil(t, err)
 	err = os.Remove(configFilePath)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 }
 
 func TestInvalidProxyProtocol(t *testing.T) {
@@ -131,19 +131,19 @@ func TestInvalidProxyProtocol(t *testing.T) {
 	confName := tempConfigName + ".json"
 	configFilePath := filepath.Join(configDir, confName)
 	err := config.LoadConfig(configDir, configName)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	sftpdConf := config.GetSFTPDConfig()
 	sftpdConf.ProxyProtocol = 10
 	c := make(map[string]sftpd.Configuration)
 	c["sftpd"] = sftpdConf
 	jsonConf, err := json.Marshal(c)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	err = ioutil.WriteFile(configFilePath, jsonConf, 0666)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	err = config.LoadConfig(configDir, tempConfigName)
 	assert.NotNil(t, err)
 	err = os.Remove(configFilePath)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 }
 
 func TestInvalidUsersBaseDir(t *testing.T) {
@@ -151,19 +151,19 @@ func TestInvalidUsersBaseDir(t *testing.T) {
 	confName := tempConfigName + ".json"
 	configFilePath := filepath.Join(configDir, confName)
 	err := config.LoadConfig(configDir, configName)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	providerConf := config.GetProviderConf()
 	providerConf.UsersBaseDir = "."
 	c := make(map[string]dataprovider.Config)
 	c["data_provider"] = providerConf
 	jsonConf, err := json.Marshal(c)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	err = ioutil.WriteFile(configFilePath, jsonConf, 0666)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	err = config.LoadConfig(configDir, tempConfigName)
 	assert.NotNil(t, err)
 	err = os.Remove(configFilePath)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 }
 
 func TestHookCompatibity(t *testing.T) {
@@ -171,36 +171,37 @@ func TestHookCompatibity(t *testing.T) {
 	confName := tempConfigName + ".json"
 	configFilePath := filepath.Join(configDir, confName)
 	err := config.LoadConfig(configDir, configName)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	providerConf := config.GetProviderConf()
 	providerConf.ExternalAuthProgram = "ext_auth_program"
 	providerConf.PreLoginProgram = "pre_login_program"
 	c := make(map[string]dataprovider.Config)
 	c["data_provider"] = providerConf
 	jsonConf, err := json.Marshal(c)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	err = ioutil.WriteFile(configFilePath, jsonConf, 0666)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	err = config.LoadConfig(configDir, tempConfigName)
+	assert.NoError(t, err)
 	providerConf = config.GetProviderConf()
 	assert.Equal(t, "ext_auth_program", providerConf.ExternalAuthHook)
 	assert.Equal(t, "pre_login_program", providerConf.PreLoginHook)
 	err = os.Remove(configFilePath)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	sftpdConf := config.GetSFTPDConfig()
 	sftpdConf.KeyboardInteractiveProgram = "key_int_program"
 	cnf := make(map[string]sftpd.Configuration)
 	cnf["sftpd"] = sftpdConf
 	jsonConf, err = json.Marshal(cnf)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	err = ioutil.WriteFile(configFilePath, jsonConf, 0666)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	err = config.LoadConfig(configDir, tempConfigName)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	sftpdConf = config.GetSFTPDConfig()
 	assert.Equal(t, "key_int_program", sftpdConf.KeyboardInteractiveHook)
 	err = os.Remove(configFilePath)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 }
 
 func TestSetGetConfig(t *testing.T) {

httpd/internal_test.go

@@ -19,6 +19,7 @@ import (
 	"github.com/drakkan/sftpgo/utils"
 	"github.com/drakkan/sftpgo/vfs"
 	"github.com/go-chi/chi"
+	"github.com/stretchr/testify/assert"
 )
 
 const (
@@ -30,25 +31,17 @@ func TestGetRespStatus(t *testing.T) {
 	var err error
 	err = &dataprovider.MethodDisabledError{}
 	respStatus := getRespStatus(err)
-	if respStatus != http.StatusForbidden {
+	assert.Equal(t, http.StatusForbidden, respStatus)
-		t.Errorf("wrong resp status extected: %d got: %d", http.StatusForbidden, respStatus)
-	}
 	err = fmt.Errorf("generic error")
 	respStatus = getRespStatus(err)
-	if respStatus != http.StatusInternalServerError {
+	assert.Equal(t, http.StatusInternalServerError, respStatus)
-		t.Errorf("wrong resp status extected: %d got: %d", http.StatusInternalServerError, respStatus)
-	}
 }
 
 func TestCheckResponse(t *testing.T) {
 	err := checkResponse(http.StatusOK, http.StatusCreated)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("check must fail")
-	}
 	err = checkResponse(http.StatusBadRequest, http.StatusBadRequest)
-	if err != nil {
+	assert.NoError(t, err)
-		t.Errorf("test must succeed, error: %v", err)
-	}
 }
 
 func TestCheckUser(t *testing.T) {
@@ -56,71 +49,51 @@ func TestCheckUser(t *testing.T) {
 	actual := &dataprovider.User{}
 	actual.Password = "password"
 	err := checkUser(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("actual password must be nil")
-	}
 	actual.Password = ""
 	err = checkUser(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("actual ID must be > 0")
-	}
 	expected.ID = 1
 	actual.ID = 2
 	err = checkUser(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("actual ID must be equal to expected ID")
-	}
 	expected.ID = 2
 	actual.ID = 2
 	expected.Permissions = make(map[string][]string)
 	expected.Permissions["/"] = []string{dataprovider.PermCreateDirs, dataprovider.PermDelete, dataprovider.PermDownload}
 	actual.Permissions = make(map[string][]string)
 	err = checkUser(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("Permissions are not equal")
-	}
 	actual.Permissions["/"] = []string{dataprovider.PermCreateDirs, dataprovider.PermCreateSymlinks}
 	err = checkUser(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("Permissions are not equal")
-	}
 	expected.Permissions["/"] = append(expected.Permissions["/"], dataprovider.PermRename)
 	err = checkUser(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("Permissions are not equal")
-	}
 	expected.Permissions = make(map[string][]string)
 	expected.Permissions["/somedir"] = []string{dataprovider.PermAny}
 	actual.Permissions = make(map[string][]string)
 	actual.Permissions["/otherdir"] = []string{dataprovider.PermCreateDirs, dataprovider.PermCreateSymlinks}
 	err = checkUser(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("Permissions are not equal")
-	}
 	expected.Permissions = make(map[string][]string)
 	actual.Permissions = make(map[string][]string)
 	actual.FsConfig.Provider = 1
 	err = checkUser(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("Fs providers are not equal")
-	}
 	actual.FsConfig.Provider = 0
 	expected.VirtualFolders = append(expected.VirtualFolders, vfs.VirtualFolder{
 		VirtualPath: "/vdir",
 		MappedPath:  os.TempDir(),
 	})
 	err = checkUser(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("Virtual folders are not equal")
-	}
 	actual.VirtualFolders = append(actual.VirtualFolders, vfs.VirtualFolder{
 		VirtualPath: "/vdir1",
 		MappedPath:  os.TempDir(),
 	})
 	err = checkUser(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("Virtual folders are not equal")
-	}
 }
 
 func TestCompareUserFilters(t *testing.T) {
@@ -131,40 +104,28 @@ func TestCompareUserFilters(t *testing.T) {
 	expected.Filters.AllowedIP = []string{}
 	actual.Filters.AllowedIP = []string{"192.168.1.2/32"}
 	err := checkUser(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("AllowedIP are not equal")
-	}
 	expected.Filters.AllowedIP = []string{"192.168.1.3/32"}
 	err = checkUser(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("AllowedIP contents are not equal")
-	}
 	expected.Filters.AllowedIP = []string{}
 	actual.Filters.AllowedIP = []string{}
 	expected.Filters.DeniedIP = []string{}
 	actual.Filters.DeniedIP = []string{"192.168.1.2/32"}
 	err = checkUser(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("DeniedIP are not equal")
-	}
 	expected.Filters.DeniedIP = []string{"192.168.1.3/32"}
 	err = checkUser(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("DeniedIP contents are not equal")
-	}
 	expected.Filters.DeniedIP = []string{}
 	actual.Filters.DeniedIP = []string{}
 	expected.Filters.DeniedLoginMethods = []string{}
 	actual.Filters.DeniedLoginMethods = []string{dataprovider.SSHLoginMethodPublicKey}
 	err = checkUser(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("Denied login methods are not equal")
-	}
 	expected.Filters.DeniedLoginMethods = []string{dataprovider.SSHLoginMethodPassword}
 	err = checkUser(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("Denied login methods contents are not equal")
-	}
 	expected.Filters.DeniedLoginMethods = []string{}
 	actual.Filters.DeniedLoginMethods = []string{}
 	expected.Filters.FileExtensions = append(expected.Filters.FileExtensions, dataprovider.ExtensionsFilter{
@@ -173,45 +134,35 @@ func TestCompareUserFilters(t *testing.T) {
 		DeniedExtensions:  []string{".zip", ".rar"},
 	})
 	err = checkUser(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("file extensons are not equal")
-	}
 	actual.Filters.FileExtensions = append(actual.Filters.FileExtensions, dataprovider.ExtensionsFilter{
 		Path:              "/sub",
 		AllowedExtensions: []string{".jpg", ".png"},
 		DeniedExtensions:  []string{".zip", ".rar"},
 	})
 	err = checkUser(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("file extensons contents are not equal")
-	}
 	actual.Filters.FileExtensions[0] = dataprovider.ExtensionsFilter{
 		Path:              "/",
 		AllowedExtensions: []string{".jpg"},
 		DeniedExtensions:  []string{".zip", ".rar"},
 	}
 	err = checkUser(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("file extensons contents are not equal")
-	}
 	actual.Filters.FileExtensions[0] = dataprovider.ExtensionsFilter{
 		Path:              "/",
 		AllowedExtensions: []string{".tiff", ".png"},
 		DeniedExtensions:  []string{".zip", ".rar"},
 	}
 	err = checkUser(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("file extensons contents are not equal")
-	}
 	actual.Filters.FileExtensions[0] = dataprovider.ExtensionsFilter{
 		Path:              "/",
 		AllowedExtensions: []string{".jpg", ".png"},
 		DeniedExtensions:  []string{".tar.gz", ".rar"},
 	}
 	err = checkUser(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("file extensons contents are not equal")
-	}
 }
 
 func TestCompareUserFields(t *testing.T) {
@@ -221,75 +172,51 @@ func TestCompareUserFields(t *testing.T) {
 	actual.Permissions = make(map[string][]string)
 	expected.Username = "test"
 	err := compareEqualsUserFields(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("Username does not match")
-	}
 	expected.Username = ""
 	expected.HomeDir = "homedir"
 	err = compareEqualsUserFields(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("HomeDir does not match")
-	}
 	expected.HomeDir = ""
 	expected.UID = 1
 	err = compareEqualsUserFields(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("UID does not match")
-	}
 	expected.UID = 0
 	expected.GID = 1
 	err = compareEqualsUserFields(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("GID does not match")
-	}
 	expected.GID = 0
 	expected.MaxSessions = 2
 	err = compareEqualsUserFields(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("MaxSessions do not match")
-	}
 	expected.MaxSessions = 0
 	expected.QuotaSize = 4096
 	err = compareEqualsUserFields(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("QuotaSize does not match")
-	}
 	expected.QuotaSize = 0
 	expected.QuotaFiles = 2
 	err = compareEqualsUserFields(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("QuotaFiles do not match")
-	}
 	expected.QuotaFiles = 0
 	expected.Permissions["/"] = []string{dataprovider.PermCreateDirs}
 	err = compareEqualsUserFields(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("Permissions are not equal")
-	}
 	expected.Permissions = nil
 	expected.UploadBandwidth = 64
 	err = compareEqualsUserFields(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("UploadBandwidth does not match")
-	}
 	expected.UploadBandwidth = 0
 	expected.DownloadBandwidth = 128
 	err = compareEqualsUserFields(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("DownloadBandwidth does not match")
-	}
 	expected.DownloadBandwidth = 0
 	expected.Status = 1
 	err = compareEqualsUserFields(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("Status does not match")
-	}
 	expected.Status = 0
 	expected.ExpirationDate = 123
 	err = compareEqualsUserFields(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("Expiration date does not match")
-	}
 }
 
 func TestCompareUserFsConfig(t *testing.T) {
@@ -297,83 +224,57 @@ func TestCompareUserFsConfig(t *testing.T) {
 	actual := &dataprovider.User{}
 	expected.FsConfig.Provider = 1
 	err := compareUserFsConfig(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("Provider does not match")
-	}
 	expected.FsConfig.Provider = 0
 	expected.FsConfig.S3Config.Bucket = "bucket"
 	err = compareUserFsConfig(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("S3 bucket does not match")
-	}
 	expected.FsConfig.S3Config.Bucket = ""
 	expected.FsConfig.S3Config.Region = "region"
 	err = compareUserFsConfig(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("S3 region does not match")
-	}
 	expected.FsConfig.S3Config.Region = ""
 	expected.FsConfig.S3Config.AccessKey = "access key"
 	err = compareUserFsConfig(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("S3 access key does not match")
-	}
 	expected.FsConfig.S3Config.AccessKey = ""
 	actual.FsConfig.S3Config.AccessSecret = "access secret"
 	err = compareUserFsConfig(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("S3 access secret does not match")
-	}
 	secret, _ := utils.EncryptData("access secret")
 	actual.FsConfig.S3Config.AccessSecret = ""
 	expected.FsConfig.S3Config.AccessSecret = secret
 	err = compareUserFsConfig(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("S3 access secret does not match")
-	}
 	expected.FsConfig.S3Config.AccessSecret = utils.RemoveDecryptionKey(secret)
 	actual.FsConfig.S3Config.AccessSecret = utils.RemoveDecryptionKey(secret) + "a"
 	err = compareUserFsConfig(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("S3 access secret does not match")
-	}
 	expected.FsConfig.S3Config.AccessSecret = "test"
 	actual.FsConfig.S3Config.AccessSecret = ""
 	err = compareUserFsConfig(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("S3 access secret does not match")
-	}
 	expected.FsConfig.S3Config.AccessSecret = ""
 	actual.FsConfig.S3Config.AccessSecret = ""
 	expected.FsConfig.S3Config.Endpoint = "http://127.0.0.1:9000/"
 	err = compareUserFsConfig(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("S3 endpoint does not match")
-	}
 	expected.FsConfig.S3Config.Endpoint = ""
 	expected.FsConfig.S3Config.StorageClass = "Standard"
 	err = compareUserFsConfig(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("S3 storage class does not match")
-	}
 	expected.FsConfig.S3Config.StorageClass = ""
 	expected.FsConfig.S3Config.KeyPrefix = "somedir/subdir"
 	err = compareUserFsConfig(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("S3 key prefix does not match")
-	}
 	expected.FsConfig.S3Config.KeyPrefix = ""
 	expected.FsConfig.S3Config.UploadPartSize = 10
 	err = compareUserFsConfig(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("S3 upload part size does not match")
-	}
 	expected.FsConfig.S3Config.UploadPartSize = 0
 	expected.FsConfig.S3Config.UploadConcurrency = 3
 	err = compareUserFsConfig(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("S3 upload concurrency does not match")
-	}
 }
 
 func TestCompareUserGCSConfig(t *testing.T) {
@@ -381,27 +282,19 @@ func TestCompareUserGCSConfig(t *testing.T) {
 	actual := &dataprovider.User{}
 	expected.FsConfig.GCSConfig.KeyPrefix = "somedir/subdir"
 	err := compareUserFsConfig(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("GCS key prefix does not match")
-	}
 	expected.FsConfig.GCSConfig.KeyPrefix = ""
 	expected.FsConfig.GCSConfig.Bucket = "bucket"
 	err = compareUserFsConfig(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("GCS bucket does not match")
-	}
 	expected.FsConfig.GCSConfig.Bucket = ""
 	expected.FsConfig.GCSConfig.StorageClass = "Standard"
 	err = compareUserFsConfig(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("GCS storage class does not match")
-	}
 	expected.FsConfig.GCSConfig.StorageClass = ""
 	expected.FsConfig.GCSConfig.AutomaticCredentials = 1
 	err = compareUserFsConfig(expected, actual)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("GCS automatic credentials does not match")
-	}
 	expected.FsConfig.GCSConfig.AutomaticCredentials = 0
 }
 
@@ -413,9 +306,7 @@ func TestGCSWebInvalidFormFile(t *testing.T) {
 	req.Header.Set("Content-Type", "application/x-www-form-urlencoded")
 	req.ParseForm()
 	_, err := getFsConfigFromUserPostFields(req)
-	if err != http.ErrNotMultipart {
+	assert.EqualError(t, err, http.ErrNotMultipart.Error())
-		t.Errorf("unexpected error: %v", err)
-	}
 }
 
 func TestApiCallsWithBadURL(t *testing.T) {
@@ -425,29 +316,17 @@ func TestApiCallsWithBadURL(t *testing.T) {
 	SetBaseURLAndCredentials(invalidURL, oldAuthUsername, oldAuthPassword)
 	u := dataprovider.User{}
 	_, _, err := UpdateUser(u, http.StatusBadRequest)
-	if err == nil {
+	assert.Error(t, err)
-		t.Error("request with invalid URL must fail")
-	}
 	_, err = RemoveUser(u, http.StatusNotFound)
-	if err == nil {
+	assert.Error(t, err)
-		t.Error("request with invalid URL must fail")
-	}
 	_, _, err = GetUsers(1, 0, "", http.StatusBadRequest)
-	if err == nil {
+	assert.Error(t, err)
-		t.Error("request with invalid URL must fail")
-	}
 	_, err = CloseConnection("non_existent_id", http.StatusNotFound)
-	if err == nil {
+	assert.Error(t, err)
-		t.Error("request with invalid URL must fail")
-	}
 	_, _, err = Dumpdata("backup.json", "", http.StatusBadRequest)
-	if err == nil {
+	assert.Error(t, err)
-		t.Error("request with invalid URL must fail")
-	}
 	_, _, err = Loaddata("/tmp/backup.json", "", "", http.StatusBadRequest)
-	if err == nil {
+	assert.Error(t, err)
-		t.Error("request with invalid URL must fail")
-	}
 	SetBaseURLAndCredentials(oldBaseURL, oldAuthUsername, oldAuthPassword)
 }
 
@@ -458,57 +337,31 @@ func TestApiCallToNotListeningServer(t *testing.T) {
 	SetBaseURLAndCredentials(inactiveURL, oldAuthUsername, oldAuthPassword)
 	u := dataprovider.User{}
 	_, _, err := AddUser(u, http.StatusBadRequest)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("request to an inactive URL must fail")
-	}
 	_, _, err = UpdateUser(u, http.StatusNotFound)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("request to an inactive URL must fail")
-	}
 	_, err = RemoveUser(u, http.StatusNotFound)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("request to an inactive URL must fail")
-	}
 	_, _, err = GetUserByID(-1, http.StatusNotFound)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("request to an inactive URL must fail")
-	}
 	_, _, err = GetUsers(100, 0, "", http.StatusOK)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("request to an inactive URL must fail")
-	}
 	_, _, err = GetQuotaScans(http.StatusOK)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("request to an inactive URL must fail")
-	}
 	_, err = StartQuotaScan(u, http.StatusNotFound)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("request to an inactive URL must fail")
-	}
 	_, _, err = GetConnections(http.StatusOK)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("request to an inactive URL must fail")
-	}
 	_, err = CloseConnection("non_existent_id", http.StatusNotFound)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("request to an inactive URL must fail")
-	}
 	_, _, err = GetVersion(http.StatusOK)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("request to an inactive URL must fail")
-	}
 	_, _, err = GetProviderStatus(http.StatusOK)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("request to an inactive URL must fail")
-	}
 	_, _, err = Dumpdata("backup.json", "0", http.StatusOK)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("request to an inactive URL must fail")
-	}
 	_, _, err = Loaddata("/tmp/backup.json", "", "", http.StatusOK)
-	if err == nil {
+	assert.Error(t, err)
-		t.Errorf("request to an inactive URL must fail")
-	}
 	SetBaseURLAndCredentials(oldBaseURL, oldAuthUsername, oldAuthPassword)
 }
 
@@ -520,66 +373,53 @@ func TestBasicAuth(t *testing.T) {
 	ioutil.WriteFile(authUserFile, authUserData, 0666)
 	httpAuth, _ = newBasicAuthProvider(authUserFile)
 	_, _, err := GetVersion(http.StatusUnauthorized)
-	if err != nil {
+	assert.NoError(t, err)
-		t.Errorf("unexpected error: %v", err)
-	}
 	SetBaseURLAndCredentials(httpBaseURL, "test1", "password1")
 	_, _, err = GetVersion(http.StatusOK)
-	if err != nil {
+	assert.NoError(t, err)
-		t.Errorf("unexpected error: %v", err)
-	}
 	SetBaseURLAndCredentials(httpBaseURL, "test1", "wrong_password")
 	resp, _ := sendHTTPRequest(http.MethodGet, buildURLRelativeToBase(metricsPath), nil, "")
 	defer resp.Body.Close()
-	if resp.StatusCode != http.StatusUnauthorized {
+	assert.Equal(t, http.StatusUnauthorized, resp.StatusCode)
-		t.Errorf("request with wrong password must fail, status code: %v", resp.StatusCode)
-	}
 	authUserData = append(authUserData, []byte("test2:$apr1$gLnIkRIf$Xr/6aJfmIrihP4b2N2tcs/\n")...)
-	ioutil.WriteFile(authUserFile, authUserData, 0666)
+	err = ioutil.WriteFile(authUserFile, authUserData, 0666)
+	assert.NoError(t, err)
 	SetBaseURLAndCredentials(httpBaseURL, "test2", "password2")
 	_, _, err = GetVersion(http.StatusOK)
-	if err != nil {
+	assert.NoError(t, err)
-		t.Errorf("unexpected error: %v", err)
-	}
 	SetBaseURLAndCredentials(httpBaseURL, "test2", "wrong_password")
 	_, _, err = GetVersion(http.StatusOK)
-	if err == nil {
+	assert.Error(t, err)
-		t.Error("request with wrong password must fail")
-	}
 	authUserData = append(authUserData, []byte("test3:$apr1$gLnIkRIf$Xr/6$aJfmIr$ihP4b2N2tcs/\n")...)
 	ioutil.WriteFile(authUserFile, authUserData, 0666)
 	SetBaseURLAndCredentials(httpBaseURL, "test3", "wrong_password")
 	_, _, err = GetVersion(http.StatusUnauthorized)
-	if err != nil {
+	assert.NoError(t, err)
-		t.Errorf("unexpected error: %v", err)
-	}
 	authUserData = append(authUserData, []byte("test4:$invalid$gLnIkRIf$Xr/6$aJfmIr$ihP4b2N2tcs/\n")...)
 	ioutil.WriteFile(authUserFile, authUserData, 0666)
 	SetBaseURLAndCredentials(httpBaseURL, "test3", "password2")
 	_, _, err = GetVersion(http.StatusUnauthorized)
-	if err != nil {
+	assert.NoError(t, err)
-		t.Errorf("unexpected error: %v", err)
-	}
 	if runtime.GOOS != "windows" {
 		authUserData = append(authUserData, []byte("test5:$apr1$gLnIkRIf$Xr/6aJfmIrihP4b2N2tcs/\n")...)
-		ioutil.WriteFile(authUserFile, authUserData, 0666)
+		err = ioutil.WriteFile(authUserFile, authUserData, 0666)
-		os.Chmod(authUserFile, 0001)
+		assert.NoError(t, err)
+		err = os.Chmod(authUserFile, 0001)
+		assert.NoError(t, err)
 		SetBaseURLAndCredentials(httpBaseURL, "test5", "password2")
 		_, _, err = GetVersion(http.StatusUnauthorized)
-		if err != nil {
+		assert.NoError(t, err)
-			t.Errorf("unexpected error: %v", err)
+		err = os.Chmod(authUserFile, 0666)
-		}
+		assert.NoError(t, err)
-		os.Chmod(authUserFile, 0666)
-
 	}
 	authUserData = append(authUserData, []byte("\"foo\"bar\"\r\n")...)
-	ioutil.WriteFile(authUserFile, authUserData, 0666)
+	err = ioutil.WriteFile(authUserFile, authUserData, 0666)
+	assert.NoError(t, err)
 	SetBaseURLAndCredentials(httpBaseURL, "test2", "password2")
 	_, _, err = GetVersion(http.StatusUnauthorized)
-	if err != nil {
+	assert.NoError(t, err)
-		t.Errorf("unexpected error: %v", err)
+	err = os.Remove(authUserFile)
-	}
+	assert.NoError(t, err)
-	os.Remove(authUserFile)
 	SetBaseURLAndCredentials(httpBaseURL, oldAuthUsername, oldAuthPassword)
 	httpAuth, _ = newBasicAuthProvider("")
 }
@@ -591,22 +431,16 @@ func TestCloseConnectionHandler(t *testing.T) {
 	req = req.WithContext(context.WithValue(req.Context(), chi.RouteCtxKey, rctx))
 	rr := httptest.NewRecorder()
 	handleCloseConnection(rr, req)
-	if rr.Code != http.StatusBadRequest {
+	assert.Equal(t, http.StatusBadRequest, rr.Code)
-		t.Errorf("Expected response code 400. Got %d", rr.Code)
-	}
 }
 
 func TestRenderInvalidTemplate(t *testing.T) {
 	tmpl, err := template.New("test").Parse("{{.Count}}")
-	if err != nil {
+	if assert.NoError(t, err) {
-		t.Errorf("error making test template: %v", err)
-	} else {
 		templates["no_match"] = tmpl
 		rw := httptest.NewRecorder()
 		renderTemplate(rw, "no_match", map[string]string{})
-		if rw.Code != http.StatusInternalServerError {
+		assert.Equal(t, http.StatusInternalServerError, rw.Code)
-			t.Errorf("invalid template rendering must fail")
-		}
 	}
 }
 
@@ -620,7 +454,5 @@ func TestQuotaScanInvalidFs(t *testing.T) {
 	}
 	sftpd.AddQuotaScan(user.Username)
 	err := doQuotaScan(user)
-	if err == nil {
+	assert.Error(t, err)
-		t.Error("quota scan with bad fs must fail")
-	}
 }