GCS uploads: check Close() error

some code simplification too
This commit is contained in:
Nicola Murino
2020-11-13 18:40:18 +01:00
parent fbd9919afa
commit 1a6863f4b1
3 changed files with 61 additions and 42 deletions

View File

@@ -218,8 +218,12 @@ func (fs *GCSFs) Create(name string, flag int) (*os.File, *PipeWriter, func(), e
}
go func() {
defer cancelFn()
defer objectWriter.Close()
n, err := io.Copy(objectWriter, r)
closeErr := objectWriter.Close()
if err == nil {
err = closeErr
}
r.CloseWithError(err) //nolint:errcheck
p.Done(err)
fsLog(fs, logger.LevelDebug, "upload completed, path: %#v, readed bytes: %v, err: %v", name, n, err)