Mirrors/sftpgo
1
0
Fork 0
mirror of https://github.com/drakkan/sftpgo.git synced 2025-12-08 07:10:56 +03:00
Code Issues Packages Projects Releases Wiki Activity

WebDAV: add support for X-OC-Mtime header

Browse Source 
it is used by Nextcloud compatible clients to set the modification time

Signed-off-by: Nicola Murino <nicola.murino@gmail.com>
This commit is contained in:
Nicola Murino
2022-11-19 19:39:28 +01:00
parent 6ebe7691db
commit 2290137868
6 changed files with 102 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
internal/webdavd/handler.go
View File

@@ -19,7 +19,9 @@ import (
"net/http"
"os"
"path"
"strconv"
"strings"
"time"
"github.com/drakkan/webdav"
@@ -36,6 +38,18 @@ type Connection struct {
request *http.Request
}
func (c *Connection) getModificationTime() time.Time {
if c.request == nil {
return time.Time{}
}
if val := c.request.Header.Get("X-OC-Mtime"); val != "" {
if unixTime, err := strconv.ParseInt(val, 10, 64); err == nil {
return time.Unix(unixTime, 0)
}
}
return time.Time{}
}
// GetClientVersion returns the connected client's version.
func (c *Connection) GetClientVersion() string {
if c.request != nil {
@@ -85,7 +99,19 @@ func (c *Connection) Rename(ctx context.Context, oldName, newName string) error
oldName = util.CleanPath(oldName)
newName = util.CleanPath(newName)
return c.BaseConnection.Rename(oldName, newName)
err := c.BaseConnection.Rename(oldName, newName)
if err == nil {
if mtime := c.getModificationTime(); !mtime.IsZero() {
attrs := &common.StatAttributes{
Flags: common.StatAttrTimes,
Atime: mtime,
Mtime: mtime,
}
setStatErr := c.SetStat(newName, attrs)
c.Log(logger.LevelDebug, "mtime header found for %q, value: %s, err: %v", newName, mtime, setStatErr)
}
}
return err
}
// Stat returns a FileInfo describing the named file/directory, or an error,
@@ -202,6 +228,8 @@ func (c *Connection) handleUploadToNewFile(fs vfs.Fs, resolvedPath, filePath, re
baseTransfer := common.NewBaseTransfer(file, c.BaseConnection, cancelFn, resolvedPath, filePath, requestPath,
common.TransferUpload, 0, 0, maxWriteSize, 0, true, fs, transferQuota)
mtime := c.getModificationTime()
baseTransfer.SetTimes(resolvedPath, mtime, mtime)
return newWebDavFile(baseTransfer, w, nil), nil
}
@@ -260,6 +288,8 @@ func (c *Connection) handleUploadToExistingFile(fs vfs.Fs, resolvedPath, filePat
baseTransfer := common.NewBaseTransfer(file, c.BaseConnection, cancelFn, resolvedPath, filePath, requestPath,
common.TransferUpload, 0, initialSize, maxWriteSize, truncatedSize, false, fs, transferQuota)
mtime := c.getModificationTime()
baseTransfer.SetTimes(resolvedPath, mtime, mtime)
return newWebDavFile(baseTransfer, w, nil), nil
}