version: only git commit and build date must be modifiable

Improved some test cases too

api/internal_test.go

@@ -1,11 +1,14 @@
 package api
 
 import (
+	"context"
 	"fmt"
 	"net/http"
+	"net/http/httptest"
 	"testing"
 
 	"github.com/drakkan/sftpgo/dataprovider"
+	"github.com/go-chi/chi"
 )
 
 const (
@@ -211,3 +214,15 @@ func TestApiCallToNotListeningServer(t *testing.T) {
 	}
 	SetBaseURL(oldBaseURL)
 }
+
+func TestCloseSFTPConnectionHandler(t *testing.T) {
+	req, _ := http.NewRequest(http.MethodDelete, activeConnectionsPath+"/connectionID", nil)
+	rctx := chi.NewRouteContext()
+	rctx.URLParams.Add("connectionID", "")
+	req = req.WithContext(context.WithValue(req.Context(), chi.RouteCtxKey, rctx))
+	rr := httptest.NewRecorder()
+	handleCloseSFTPConnection(rr, req)
+	if rr.Code != http.StatusBadRequest {
+		t.Errorf("Expected response code 400. Got %d", rr.Code)
+	}
+}

api/router.go

@@ -40,16 +40,7 @@ func initializeRouter() {
 	})
 
 	router.Delete(activeConnectionsPath+"/{connectionID}", func(w http.ResponseWriter, r *http.Request) {
-		connectionID := chi.URLParam(r, "connectionID")
-		if connectionID == "" {
-			sendAPIResponse(w, r, nil, "connectionID is mandatory", http.StatusBadRequest)
-			return
-		}
-		if sftpd.CloseActiveConnection(connectionID) {
-			sendAPIResponse(w, r, nil, "Connection closed", http.StatusOK)
-		} else {
-			sendAPIResponse(w, r, nil, "Not Found", http.StatusNotFound)
-		}
+		handleCloseSFTPConnection(w, r)
 	})
 
 	router.Get(quotaScanPath, func(w http.ResponseWriter, r *http.Request) {
@@ -80,3 +71,16 @@ func initializeRouter() {
 		deleteUser(w, r)
 	})
 }
+
+func handleCloseSFTPConnection(w http.ResponseWriter, r *http.Request) {
+	connectionID := chi.URLParam(r, "connectionID")
+	if connectionID == "" {
+		sendAPIResponse(w, r, nil, "connectionID is mandatory", http.StatusBadRequest)
+		return
+	}
+	if sftpd.CloseActiveConnection(connectionID) {
+		sendAPIResponse(w, r, nil, "Connection closed", http.StatusOK)
+	} else {
+		sendAPIResponse(w, r, nil, "Not Found", http.StatusNotFound)
+	}
+}