Mirrors/sftpgo
1
0
Fork 0
mirror of https://github.com/drakkan/sftpgo.git synced 2025-12-06 14:20:55 +03:00
Code Issues Packages Projects Releases Wiki Activity

allow to restrict the env vars passed to plugins

Browse Source 
Signed-off-by: Nicola Murino <nicola.murino@gmail.com>
This commit is contained in:
Nicola Murino
2023-10-29 15:19:30 +01:00
parent 9a7a3b00dc
commit 5c938e46b7
10 changed files with 90 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
internal/config/config_test.go
View File

@@ -693,6 +693,9 @@ func TestPluginsFromEnv(t *testing.T) {
os.Setenv("SFTPGO_PLUGINS__0__KMS_OPTIONS__SCHEME", kms.SchemeAWS)
os.Setenv("SFTPGO_PLUGINS__0__KMS_OPTIONS__ENCRYPTED_STATUS", kms.SecretStatusAWS)
os.Setenv("SFTPGO_PLUGINS__0__AUTH_OPTIONS__SCOPE", "14")
os.Setenv("SFTPGO_PLUGINS__0__ENV_PREFIX", "prefix_")
os.Setenv("SFTPGO_PLUGINS__0__ENV_VARS", "a, b")
t.Cleanup(func() {
os.Unsetenv("SFTPGO_PLUGINS__0__TYPE")
os.Unsetenv("SFTPGO_PLUGINS__0__NOTIFIER_OPTIONS__FS_EVENTS")
@@ -708,6 +711,8 @@ func TestPluginsFromEnv(t *testing.T) {
os.Unsetenv("SFTPGO_PLUGINS__0__KMS_OPTIONS__SCHEME")
os.Unsetenv("SFTPGO_PLUGINS__0__KMS_OPTIONS__ENCRYPTED_STATUS")
os.Unsetenv("SFTPGO_PLUGINS__0__AUTH_OPTIONS__SCOPE")
os.Unsetenv("SFTPGO_PLUGINS__0__ENV_PREFIX")
os.Unsetenv("SFTPGO_PLUGINS__0__ENV_VARS")
})
err := config.LoadConfig(configDir, "")
@@ -739,6 +744,10 @@ func TestPluginsFromEnv(t *testing.T) {
require.Equal(t, kms.SchemeAWS, pluginConf.KMSOptions.Scheme)
require.Equal(t, kms.SecretStatusAWS, pluginConf.KMSOptions.EncryptedStatus)
require.Equal(t, 14, pluginConf.AuthOptions.Scope)
require.Equal(t, "prefix_", pluginConf.EnvPrefix)
require.Len(t, pluginConf.EnvVars, 2)
assert.Equal(t, "a", pluginConf.EnvVars[0])
assert.Equal(t, "b", pluginConf.EnvVars[1])
cfg := make(map[string]any)
cfg["plugins"] = pluginConf
@@ -754,6 +763,8 @@ func TestPluginsFromEnv(t *testing.T) {
os.Setenv("SFTPGO_PLUGINS__0__AUTO_MTLS", "0")
os.Setenv("SFTPGO_PLUGINS__0__KMS_OPTIONS__SCHEME", kms.SchemeVaultTransit)
os.Setenv("SFTPGO_PLUGINS__0__KMS_OPTIONS__ENCRYPTED_STATUS", kms.SecretStatusVaultTransit)
os.Setenv("SFTPGO_PLUGINS__0__ENV_PREFIX", "")
os.Setenv("SFTPGO_PLUGINS__0__ENV_VARS", "")
err = config.LoadConfig(configDir, confName)
assert.NoError(t, err)
pluginsConf = config.GetPluginsConfig()
@@ -778,6 +789,8 @@ func TestPluginsFromEnv(t *testing.T) {
require.Equal(t, kms.SchemeVaultTransit, pluginConf.KMSOptions.Scheme)
require.Equal(t, kms.SecretStatusVaultTransit, pluginConf.KMSOptions.EncryptedStatus)
require.Equal(t, 14, pluginConf.AuthOptions.Scope)
assert.Empty(t, pluginConf.EnvPrefix)
assert.Len(t, pluginConf.EnvVars, 0)
err = os.Remove(configFilePath)
assert.NoError(t, err)