From 6270b2c2d349c30e0428c9ba0bef622f95bd9183 Mon Sep 17 00:00:00 2001
From: Nicola Murino <nicola.murino@gmail.com>
Date: Mon, 19 Dec 2022 18:10:40 +0100
Subject: [PATCH] eventmanager: log a get task error only when required

Signed-off-by: Nicola Murino <nicola.murino@gmail.com>
---
 internal/common/eventmanager.go | 28 +++++++++++++++-------------
 1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/internal/common/eventmanager.go b/internal/common/eventmanager.go
index 5d0bef0f..15ccbef6 100644
--- a/internal/common/eventmanager.go
+++ b/internal/common/eventmanager.go
@@ -2096,20 +2096,22 @@ type eventCronJob struct {
 func (j *eventCronJob) getTask(rule dataprovider.EventRule) (dataprovider.Task, error) {
 	if rule.GuardFromConcurrentExecution() {
 		task, err := dataprovider.GetTaskByName(rule.Name)
-		if _, ok := err.(*util.RecordNotFoundError); ok {
-			eventManagerLog(logger.LevelDebug, "adding task for rule %q", rule.Name)
-			task = dataprovider.Task{
-				Name:     rule.Name,
-				UpdateAt: 0,
-				Version:  0,
+		if err != nil {
+			if _, ok := err.(*util.RecordNotFoundError); ok {
+				eventManagerLog(logger.LevelDebug, "adding task for rule %q", rule.Name)
+				task = dataprovider.Task{
+					Name:     rule.Name,
+					UpdateAt: 0,
+					Version:  0,
+				}
+				err = dataprovider.AddTask(rule.Name)
+				if err != nil {
+					eventManagerLog(logger.LevelWarn, "unable to add task for rule %q: %v", rule.Name, err)
+					return task, err
+				}
+			} else {
+				eventManagerLog(logger.LevelWarn, "unable to get task for rule %q: %v", rule.Name, err)
 			}
-			err = dataprovider.AddTask(rule.Name)
-			if err != nil {
-				eventManagerLog(logger.LevelWarn, "unable to add task for rule %q: %v", rule.Name, err)
-				return task, err
-			}
-		} else {
-			eventManagerLog(logger.LevelWarn, "unable to get task for rule %q: %v", rule.Name, err)
 		}
 		return task, err
 	}