Mirrors/sftpgo
1
0
Fork 0
mirror of https://github.com/drakkan/sftpgo.git synced 2025-12-06 14:20:55 +03:00
Code Issues Packages Projects Releases Wiki Activity

WebAdmin: allow to create admins with an unusable password

Browse Source 
Signed-off-by: Nicola Murino <nicola.murino@gmail.com>
This commit is contained in:
Nicola Murino
2025-01-25 16:40:53 +01:00
parent 48258f6e67
commit 70f8b4d495
2 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
internal/httpd/httpd_test.go
View File

@@ -20871,13 +20871,6 @@ func TestWebAdminBasicMock(t *testing.T) {
assert.Contains(t, rr.Body.String(), util.I18nError500Message) assert.Contains(t, rr.Body.String(), util.I18nError500Message)
form.Set("default_users_expiration", "10") form.Set("default_users_expiration", "10")
req, _ = http.NewRequest(http.MethodPost, webAdminPath, bytes.NewBuffer([]byte(form.Encode())))
req.RemoteAddr = defaultRemoteAddr
req.Header.Set("Content-Type", "application/x-www-form-urlencoded")
setJWTCookieForReq(req, token)
rr = executeRequest(req)
checkResponseCode(t, http.StatusOK, rr)
form.Set("password", admin.Password) form.Set("password", admin.Password)
req, _ = http.NewRequest(http.MethodPost, webAdminPath, bytes.NewBuffer([]byte(form.Encode()))) req, _ = http.NewRequest(http.MethodPost, webAdminPath, bytes.NewBuffer([]byte(form.Encode())))
req.RemoteAddr = defaultRemoteAddr req.RemoteAddr = defaultRemoteAddr

6
internal/httpd/webadmin.go
View File

@@ -3111,7 +3111,11 @@ func (s *httpdServer) handleWebAddAdminPost(w http.ResponseWriter, r *http.Reque
s.renderAddUpdateAdminPage(w, r, &admin, err, true) s.renderAddUpdateAdminPage(w, r, &admin, err, true)
return return
} }
if admin.Password == "" && s.binding.isWebAdminLoginFormDisabled() { if admin.Password == "" {
// Administrators can be used with OpenID Connect or for authentication
// via API key, in these cases the password is not necessary, we create
// a non-usable one. This feature is only useful for WebAdmin, in REST
// API you can create an unusable password externally.
admin.Password = util.GenerateUniqueID() admin.Password = util.GenerateUniqueID()
} }
ipAddr := util.GetIPFromRemoteAddress(r.RemoteAddr) ipAddr := util.GetIPFromRemoteAddress(r.RemoteAddr)