Mirrors/sftpgo
1
0
Fork 0
mirror of https://github.com/drakkan/sftpgo.git synced 2025-12-08 07:10:56 +03:00
Code Issues Packages Projects Releases Wiki Activity

metrics: reduce complexity for AddLoginResult method

Browse Source 
fix a gocyclo warning
This commit is contained in:
Nicola Murino
2021-02-28 12:23:48 +01:00
parent a6e36e7cad
commit 901cafc6da
1 changed files with 42 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

76
metrics/metrics.go
View File

@@ -830,44 +830,52 @@ func AddLoginAttempt(authMethod string) {
} }
} }
func incLoginOK(authMethod string) {
totalLoginOK.Inc()
switch authMethod {
case loginMethodPublicKey:
totalKeyLoginOK.Inc()
case loginMethodKeyboardInteractive:
totalInteractiveLoginOK.Inc()
case loginMethodKeyAndPassword:
totalKeyAndPasswordLoginOK.Inc()
case loginMethodKeyAndKeyboardInt:
totalKeyAndKeyIntLoginOK.Inc()
case loginMethodTLSCertificate:
totalTLSCertLoginOK.Inc()
case loginMethodTLSCertificateAndPwd:
totalTLSCertAndPwdLoginOK.Inc()
default:
totalPasswordLoginOK.Inc()
}
}
func incLoginFailed(authMethod string) {
totalLoginFailed.Inc()
switch authMethod {
case loginMethodPublicKey:
totalKeyLoginFailed.Inc()
case loginMethodKeyboardInteractive:
totalInteractiveLoginFailed.Inc()
case loginMethodKeyAndPassword:
totalKeyAndPasswordLoginFailed.Inc()
case loginMethodKeyAndKeyboardInt:
totalKeyAndKeyIntLoginFailed.Inc()
case loginMethodTLSCertificate:
totalTLSCertLoginFailed.Inc()
case loginMethodTLSCertificateAndPwd:
totalTLSCertAndPwdLoginFailed.Inc()
default:
totalPasswordLoginFailed.Inc()
}
}
// AddLoginResult increments the metrics for login results // AddLoginResult increments the metrics for login results
func AddLoginResult(authMethod string, err error) { func AddLoginResult(authMethod string, err error) {
if err == nil { if err == nil {
totalLoginOK.Inc() incLoginOK(authMethod)
switch authMethod {
case loginMethodPublicKey:
totalKeyLoginOK.Inc()
case loginMethodKeyboardInteractive:
totalInteractiveLoginOK.Inc()
case loginMethodKeyAndPassword:
totalKeyAndPasswordLoginOK.Inc()
case loginMethodKeyAndKeyboardInt:
totalKeyAndKeyIntLoginOK.Inc()
case loginMethodTLSCertificate:
totalTLSCertLoginOK.Inc()
case loginMethodTLSCertificateAndPwd:
totalTLSCertAndPwdLoginOK.Inc()
default:
totalPasswordLoginOK.Inc()
}
} else { } else {
totalLoginFailed.Inc() incLoginFailed(authMethod)
switch authMethod {
case loginMethodPublicKey:
totalKeyLoginFailed.Inc()
case loginMethodKeyboardInteractive:
totalInteractiveLoginFailed.Inc()
case loginMethodKeyAndPassword:
totalKeyAndPasswordLoginFailed.Inc()
case loginMethodKeyAndKeyboardInt:
totalKeyAndKeyIntLoginFailed.Inc()
case loginMethodTLSCertificate:
totalTLSCertLoginFailed.Inc()
case loginMethodTLSCertificateAndPwd:
totalTLSCertAndPwdLoginFailed.Inc()
default:
totalPasswordLoginFailed.Inc()
}
} }
} }