Mirrors/sftpgo
1
0
Fork 0
mirror of https://github.com/drakkan/sftpgo.git synced 2025-12-07 06:40:54 +03:00
Code Issues Packages Projects Releases Wiki Activity

sftpd actions: execute defined command on error too

Browse Source 
add a new field inside the notification to indicate if an error is
detected
This commit is contained in:
Nicola Murino
2020-04-03 19:25:38 +02:00
parent 9046acbe68
commit 94b46e57f1
6 changed files with 38 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
sftpd/internal_test.go
View File

@@ -131,7 +131,7 @@ func TestNewActionNotification(t *testing.T) {
user.FsConfig.GCSConfig = vfs.GCSFsConfig{
Bucket: "gcsbucket",
}
a := newActionNotification(user, operationDownload, "path", "target", "", 123)
a := newActionNotification(user, operationDownload, "path", "target", "", 123, nil)
if a.Username != "username" {
t.Errorf("unexpected username")
}
@@ -142,7 +142,7 @@ func TestNewActionNotification(t *testing.T) {
t.Errorf("unexpected endpoint")
}
user.FsConfig.Provider = 1
a = newActionNotification(user, operationDownload, "path", "target", "", 123)
a = newActionNotification(user, operationDownload, "path", "target", "", 123, nil)
if a.Bucket != "s3bucket" {
t.Errorf("unexpected s3 bucket")
}
@@ -150,7 +150,7 @@ func TestNewActionNotification(t *testing.T) {
t.Errorf("unexpected endpoint")
}
user.FsConfig.Provider = 2
a = newActionNotification(user, operationDownload, "path", "target", "", 123)
a = newActionNotification(user, operationDownload, "path", "target", "", 123, nil)
if a.Bucket != "gcsbucket" {
t.Errorf("unexpected gcs bucket")
}
@@ -173,17 +173,17 @@ func TestWrongActions(t *testing.T) {
user := dataprovider.User{
Username: "username",
}
err := executeAction(newActionNotification(user, operationDownload, "path", "", "", 0))
err := executeAction(newActionNotification(user, operationDownload, "path", "", "", 0, nil))
if err == nil {
t.Errorf("action with bad command must fail")
}
err = executeAction(newActionNotification(user, operationDelete, "path", "", "", 0))
err = executeAction(newActionNotification(user, operationDelete, "path", "", "", 0, nil))
if err != nil {
t.Errorf("action not configured must silently fail")
}
actions.Command = ""
actions.HTTPNotificationURL = "http://foo\x7f.com/"
err = executeAction(newActionNotification(user, operationDownload, "path", "", "", 0))
err = executeAction(newActionNotification(user, operationDownload, "path", "", "", 0, nil))
if err == nil {
t.Errorf("action with bad url must fail")
}
@@ -200,7 +200,7 @@ func TestActionHTTP(t *testing.T) {
user := dataprovider.User{
Username: "username",
}
err := executeAction(newActionNotification(user, operationDownload, "path", "", "", 0))
err := executeAction(newActionNotification(user, operationDownload, "path", "", "", 0, nil))
if err != nil {
t.Errorf("unexpected error: %v", err)
}