Mirrors/sshj
1
0
Fork 0
mirror of https://github.com/hierynomus/sshj.git synced 2025-12-06 23:30:55 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

add Buffer capacity check for type UInt64 (#454)

Browse Source
This commit is contained in:
OlivierSalasc
2018-09-27 14:49:25 +02:00
committed by Jeroen van Erp
parent 4de9f8ab9f
commit 17c368f9c2
2 changed files with 25 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/main/java/net/schmizz/sshj/common/Buffer.java
View File

@@ -372,6 +372,7 @@ public class Buffer<T extends Buffer<T>> {
@SuppressWarnings("unchecked")
private T putUInt64Unchecked(long uint64) {
ensureCapacity(8);
data[wpos++] = (byte) (uint64 >> 56);
data[wpos++] = (byte) (uint64 >> 48);
data[wpos++] = (byte) (uint64 >> 40);

24
src/test/java/net/schmizz/sshj/common/BufferTest.java
View File

@@ -146,4 +146,28 @@ public class BufferTest {
assertArrayEquals("Value: " + value, bytesLong, bytesBigInt);
}
}
@Test
public void shouldExpandCapacityOfUInt32(){
PlainBuffer buf = new PlainBuffer();
for(int i=0;i<Buffer.DEFAULT_SIZE+1;i+=4) {
buf.putUInt32(1l);
}
/* Buffer should have been expanded at this point*/
assertEquals(Buffer.DEFAULT_SIZE*2,buf.data.length);
}
@Test
public void shouldExpandCapacityOfUInt64(){
BigInteger bigUint64 = BigInteger.valueOf(Long.MAX_VALUE);
PlainBuffer buf = new PlainBuffer();
assertEquals(Buffer.DEFAULT_SIZE,buf.data.length);
for(int i=0;i<Buffer.DEFAULT_SIZE+1;i+=8) {
buf.putUInt64(bigUint64.longValue());
}
/* Buffer should have been expanded at this point*/
assertEquals(Buffer.DEFAULT_SIZE*2,buf.data.length);
}
}