From 17eb5cff0f6f452c1b35d19920706af33add3d8c Mon Sep 17 00:00:00 2001
From: Shikhar Bhushan <shikhar@schmizz.net>
Date: Sun, 8 Aug 2010 17:55:30 +0100
Subject: [PATCH] consolidate bitmask logic and fix subtle bug...

---
 src/main/java/net/schmizz/sshj/xfer/FilePermission.java | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/main/java/net/schmizz/sshj/xfer/FilePermission.java b/src/main/java/net/schmizz/sshj/xfer/FilePermission.java
index 7db86319..969a6f71 100644
--- a/src/main/java/net/schmizz/sshj/xfer/FilePermission.java
+++ b/src/main/java/net/schmizz/sshj/xfer/FilePermission.java
@@ -68,13 +68,13 @@ public enum FilePermission {
     }
 
     public boolean isIn(int mask) {
-        return (mask & val) == mask;
+        return (mask & val) == val;
     }
 
     public static Set<FilePermission> fromMask(int mask) {
-        List<FilePermission> perms = new LinkedList<FilePermission>();
+        final List<FilePermission> perms = new LinkedList<FilePermission>();
         for (FilePermission p : FilePermission.values())
-            if ((mask & p.val) == p.val)
+            if (p.isIn(mask))
                 perms.add(p);
         return new HashSet<FilePermission>(perms);
     }