diff --git a/src/main/java/net/schmizz/sshj/DefaultConfig.java b/src/main/java/net/schmizz/sshj/DefaultConfig.java index 62ca3e89..3db2685a 100644 --- a/src/main/java/net/schmizz/sshj/DefaultConfig.java +++ b/src/main/java/net/schmizz/sshj/DefaultConfig.java @@ -24,34 +24,19 @@ import net.schmizz.sshj.common.SecurityUtils; import net.schmizz.sshj.signature.SignatureDSA; import net.schmizz.sshj.signature.SignatureECDSA; import net.schmizz.sshj.signature.SignatureRSA; -import net.schmizz.sshj.transport.cipher.AES128CBC; -import net.schmizz.sshj.transport.cipher.AES128CTR; -import net.schmizz.sshj.transport.cipher.AES192CBC; -import net.schmizz.sshj.transport.cipher.AES192CTR; -import net.schmizz.sshj.transport.cipher.AES256CBC; -import net.schmizz.sshj.transport.cipher.AES256CTR; -import net.schmizz.sshj.transport.cipher.BlowfishCBC; -import net.schmizz.sshj.transport.cipher.Cipher; -import net.schmizz.sshj.transport.cipher.TripleDESCBC; +import net.schmizz.sshj.transport.cipher.*; import net.schmizz.sshj.transport.compression.NoneCompression; import net.schmizz.sshj.transport.kex.*; -import net.schmizz.sshj.transport.mac.HMACMD5; -import net.schmizz.sshj.transport.mac.HMACMD596; -import net.schmizz.sshj.transport.mac.HMACSHA1; -import net.schmizz.sshj.transport.mac.HMACSHA196; -import net.schmizz.sshj.transport.mac.HMACSHA2256; -import net.schmizz.sshj.transport.mac.HMACSHA2512; +import net.schmizz.sshj.transport.mac.*; import net.schmizz.sshj.transport.random.BouncyCastleRandom; import net.schmizz.sshj.transport.random.JCERandom; import net.schmizz.sshj.transport.random.SingletonRandomFactory; import net.schmizz.sshj.userauth.keyprovider.OpenSSHKeyFile; import net.schmizz.sshj.userauth.keyprovider.PKCS8KeyFile; import net.schmizz.sshj.userauth.keyprovider.PuTTYKeyFile; - import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import java.awt.image.ByteLookupTable; import java.util.Arrays; import java.util.Iterator; import java.util.LinkedList; diff --git a/src/main/java/net/schmizz/sshj/SSHClient.java b/src/main/java/net/schmizz/sshj/SSHClient.java index daecc5a6..1b62fd03 100644 --- a/src/main/java/net/schmizz/sshj/SSHClient.java +++ b/src/main/java/net/schmizz/sshj/SSHClient.java @@ -45,17 +45,8 @@ import net.schmizz.sshj.transport.verification.OpenSSHKnownHosts; import net.schmizz.sshj.userauth.UserAuth; import net.schmizz.sshj.userauth.UserAuthException; import net.schmizz.sshj.userauth.UserAuthImpl; -import net.schmizz.sshj.userauth.keyprovider.FileKeyProvider; -import net.schmizz.sshj.userauth.keyprovider.KeyFormat; -import net.schmizz.sshj.userauth.keyprovider.KeyPairWrapper; -import net.schmizz.sshj.userauth.keyprovider.KeyProvider; -import net.schmizz.sshj.userauth.keyprovider.KeyProviderUtil; -import net.schmizz.sshj.userauth.method.AuthGssApiWithMic; -import net.schmizz.sshj.userauth.method.AuthKeyboardInteractive; -import net.schmizz.sshj.userauth.method.AuthMethod; -import net.schmizz.sshj.userauth.method.AuthPassword; -import net.schmizz.sshj.userauth.method.AuthPublickey; -import net.schmizz.sshj.userauth.method.PasswordResponseProvider; +import net.schmizz.sshj.userauth.keyprovider.*; +import net.schmizz.sshj.userauth.method.*; import net.schmizz.sshj.userauth.password.PasswordFinder; import net.schmizz.sshj.userauth.password.PasswordUpdateProvider; import net.schmizz.sshj.userauth.password.PasswordUtils; @@ -66,18 +57,13 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; import javax.security.auth.login.LoginContext; - import java.io.Closeable; import java.io.File; import java.io.IOException; import java.net.ServerSocket; import java.security.KeyPair; import java.security.PublicKey; -import java.util.ArrayList; -import java.util.Arrays; -import java.util.Deque; -import java.util.LinkedList; -import java.util.List; +import java.util.*; /** * Secure SHell client API. diff --git a/src/main/java/net/schmizz/sshj/common/SecurityUtils.java b/src/main/java/net/schmizz/sshj/common/SecurityUtils.java index f6fcad3d..4453d37e 100644 --- a/src/main/java/net/schmizz/sshj/common/SecurityUtils.java +++ b/src/main/java/net/schmizz/sshj/common/SecurityUtils.java @@ -23,14 +23,7 @@ import javax.crypto.Cipher; import javax.crypto.KeyAgreement; import javax.crypto.Mac; import javax.crypto.NoSuchPaddingException; -import java.security.GeneralSecurityException; -import java.security.KeyFactory; -import java.security.KeyPairGenerator; -import java.security.MessageDigest; -import java.security.NoSuchAlgorithmException; -import java.security.NoSuchProviderException; -import java.security.PublicKey; -import java.security.Signature; +import java.security.*; // TODO refactor @@ -259,4 +252,4 @@ public class SecurityUtils { } } -} \ No newline at end of file +} diff --git a/src/main/java/net/schmizz/sshj/connection/ConnectionImpl.java b/src/main/java/net/schmizz/sshj/connection/ConnectionImpl.java index 2f8ddc59..6fa7ca47 100644 --- a/src/main/java/net/schmizz/sshj/connection/ConnectionImpl.java +++ b/src/main/java/net/schmizz/sshj/connection/ConnectionImpl.java @@ -20,12 +20,7 @@ import net.schmizz.concurrent.Promise; import net.schmizz.keepalive.KeepAlive; import net.schmizz.keepalive.KeepAliveProvider; import net.schmizz.sshj.AbstractService; -import net.schmizz.sshj.common.Buffer; -import net.schmizz.sshj.common.DisconnectReason; -import net.schmizz.sshj.common.ErrorNotifiable; -import net.schmizz.sshj.common.Message; -import net.schmizz.sshj.common.SSHException; -import net.schmizz.sshj.common.SSHPacket; +import net.schmizz.sshj.common.*; import net.schmizz.sshj.connection.channel.Channel; import net.schmizz.sshj.connection.channel.OpenFailException.Reason; import net.schmizz.sshj.connection.channel.forwarded.ForwardedChannelOpener; diff --git a/src/main/java/net/schmizz/sshj/connection/channel/AbstractChannel.java b/src/main/java/net/schmizz/sshj/connection/channel/AbstractChannel.java index 56979fa4..647c64dd 100644 --- a/src/main/java/net/schmizz/sshj/connection/channel/AbstractChannel.java +++ b/src/main/java/net/schmizz/sshj/connection/channel/AbstractChannel.java @@ -17,13 +17,7 @@ package net.schmizz.sshj.connection.channel; import net.schmizz.concurrent.ErrorDeliveryUtil; import net.schmizz.concurrent.Event; -import net.schmizz.sshj.common.Buffer; -import net.schmizz.sshj.common.ByteArrayUtils; -import net.schmizz.sshj.common.DisconnectReason; -import net.schmizz.sshj.common.IOUtils; -import net.schmizz.sshj.common.Message; -import net.schmizz.sshj.common.SSHException; -import net.schmizz.sshj.common.SSHPacket; +import net.schmizz.sshj.common.*; import net.schmizz.sshj.connection.Connection; import net.schmizz.sshj.connection.ConnectionException; import net.schmizz.sshj.transport.Transport; @@ -402,4 +396,4 @@ public abstract class AbstractChannel } -} \ No newline at end of file +} diff --git a/src/main/java/net/schmizz/sshj/connection/channel/ChannelInputStream.java b/src/main/java/net/schmizz/sshj/connection/channel/ChannelInputStream.java index 4bc9561f..1839d5d2 100644 --- a/src/main/java/net/schmizz/sshj/connection/channel/ChannelInputStream.java +++ b/src/main/java/net/schmizz/sshj/connection/channel/ChannelInputStream.java @@ -15,11 +15,7 @@ */ package net.schmizz.sshj.connection.channel; -import net.schmizz.sshj.common.Buffer; -import net.schmizz.sshj.common.ErrorNotifiable; -import net.schmizz.sshj.common.Message; -import net.schmizz.sshj.common.SSHException; -import net.schmizz.sshj.common.SSHPacket; +import net.schmizz.sshj.common.*; import net.schmizz.sshj.connection.ConnectionException; import net.schmizz.sshj.transport.Transport; import net.schmizz.sshj.transport.TransportException; diff --git a/src/main/java/net/schmizz/sshj/connection/channel/ChannelOutputStream.java b/src/main/java/net/schmizz/sshj/connection/channel/ChannelOutputStream.java index e8bad1db..184c2a55 100644 --- a/src/main/java/net/schmizz/sshj/connection/channel/ChannelOutputStream.java +++ b/src/main/java/net/schmizz/sshj/connection/channel/ChannelOutputStream.java @@ -15,11 +15,7 @@ */ package net.schmizz.sshj.connection.channel; -import net.schmizz.sshj.common.Buffer; -import net.schmizz.sshj.common.ErrorNotifiable; -import net.schmizz.sshj.common.Message; -import net.schmizz.sshj.common.SSHException; -import net.schmizz.sshj.common.SSHPacket; +import net.schmizz.sshj.common.*; import net.schmizz.sshj.connection.ConnectionException; import net.schmizz.sshj.transport.Transport; import net.schmizz.sshj.transport.TransportException; diff --git a/src/main/java/net/schmizz/sshj/connection/channel/direct/LocalPortForwarder.java b/src/main/java/net/schmizz/sshj/connection/channel/direct/LocalPortForwarder.java index 1721e5a8..9abdb6f3 100644 --- a/src/main/java/net/schmizz/sshj/connection/channel/direct/LocalPortForwarder.java +++ b/src/main/java/net/schmizz/sshj/connection/channel/direct/LocalPortForwarder.java @@ -21,7 +21,6 @@ import net.schmizz.sshj.common.SSHPacket; import net.schmizz.sshj.common.StreamCopier; import net.schmizz.sshj.connection.Connection; import net.schmizz.sshj.connection.channel.SocketStreamCopyMonitor; - import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/src/main/java/net/schmizz/sshj/connection/channel/direct/SessionChannel.java b/src/main/java/net/schmizz/sshj/connection/channel/direct/SessionChannel.java index 57ccb08c..c28da4be 100644 --- a/src/main/java/net/schmizz/sshj/connection/channel/direct/SessionChannel.java +++ b/src/main/java/net/schmizz/sshj/connection/channel/direct/SessionChannel.java @@ -15,12 +15,7 @@ */ package net.schmizz.sshj.connection.channel.direct; -import net.schmizz.sshj.common.Buffer; -import net.schmizz.sshj.common.DisconnectReason; -import net.schmizz.sshj.common.IOUtils; -import net.schmizz.sshj.common.SSHException; -import net.schmizz.sshj.common.SSHPacket; -import net.schmizz.sshj.common.SSHRuntimeException; +import net.schmizz.sshj.common.*; import net.schmizz.sshj.connection.Connection; import net.schmizz.sshj.connection.ConnectionException; import net.schmizz.sshj.connection.channel.ChannelInputStream; diff --git a/src/main/java/net/schmizz/sshj/sftp/PacketReader.java b/src/main/java/net/schmizz/sshj/sftp/PacketReader.java index 5df50103..a671db75 100644 --- a/src/main/java/net/schmizz/sshj/sftp/PacketReader.java +++ b/src/main/java/net/schmizz/sshj/sftp/PacketReader.java @@ -17,7 +17,6 @@ package net.schmizz.sshj.sftp; import net.schmizz.concurrent.Promise; import net.schmizz.sshj.common.SSHException; - import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/src/main/java/net/schmizz/sshj/sftp/RandomAccessRemoteFile.java b/src/main/java/net/schmizz/sshj/sftp/RandomAccessRemoteFile.java index 9591d900..3ee6a882 100644 --- a/src/main/java/net/schmizz/sshj/sftp/RandomAccessRemoteFile.java +++ b/src/main/java/net/schmizz/sshj/sftp/RandomAccessRemoteFile.java @@ -15,12 +15,7 @@ */ package net.schmizz.sshj.sftp; -import java.io.DataInput; -import java.io.DataInputStream; -import java.io.DataOutput; -import java.io.DataOutputStream; -import java.io.EOFException; -import java.io.IOException; +import java.io.*; public class RandomAccessRemoteFile implements DataInput, DataOutput { diff --git a/src/main/java/net/schmizz/sshj/sftp/SFTPClient.java b/src/main/java/net/schmizz/sshj/sftp/SFTPClient.java index b474edb1..8ebe1776 100644 --- a/src/main/java/net/schmizz/sshj/sftp/SFTPClient.java +++ b/src/main/java/net/schmizz/sshj/sftp/SFTPClient.java @@ -23,11 +23,7 @@ import org.slf4j.LoggerFactory; import java.io.Closeable; import java.io.IOException; -import java.util.Deque; -import java.util.EnumSet; -import java.util.LinkedList; -import java.util.List; -import java.util.Set; +import java.util.*; public class SFTPClient implements Closeable { diff --git a/src/main/java/net/schmizz/sshj/sftp/SFTPFileTransfer.java b/src/main/java/net/schmizz/sshj/sftp/SFTPFileTransfer.java index ec8f0caf..0af1a12e 100644 --- a/src/main/java/net/schmizz/sshj/sftp/SFTPFileTransfer.java +++ b/src/main/java/net/schmizz/sshj/sftp/SFTPFileTransfer.java @@ -17,19 +17,12 @@ package net.schmizz.sshj.sftp; import net.schmizz.sshj.common.StreamCopier; import net.schmizz.sshj.sftp.Response.StatusCode; -import net.schmizz.sshj.xfer.AbstractFileTransfer; -import net.schmizz.sshj.xfer.FileSystemFile; -import net.schmizz.sshj.xfer.FileTransfer; -import net.schmizz.sshj.xfer.LocalDestFile; -import net.schmizz.sshj.xfer.LocalFileFilter; -import net.schmizz.sshj.xfer.LocalSourceFile; -import net.schmizz.sshj.xfer.TransferListener; +import net.schmizz.sshj.xfer.*; import java.io.IOException; import java.io.InputStream; import java.io.OutputStream; import java.util.EnumSet; -import java.util.List; public class SFTPFileTransfer extends AbstractFileTransfer diff --git a/src/main/java/net/schmizz/sshj/signature/SignatureDSA.java b/src/main/java/net/schmizz/sshj/signature/SignatureDSA.java index 8b4edf74..12305efc 100644 --- a/src/main/java/net/schmizz/sshj/signature/SignatureDSA.java +++ b/src/main/java/net/schmizz/sshj/signature/SignatureDSA.java @@ -15,11 +15,11 @@ */ package net.schmizz.sshj.signature; -import java.security.SignatureException; - import net.schmizz.sshj.common.KeyType; import net.schmizz.sshj.common.SSHRuntimeException; +import java.security.SignatureException; + /** DSA {@link Signature} */ public class SignatureDSA extends AbstractSignature { diff --git a/src/main/java/net/schmizz/sshj/signature/SignatureECDSA.java b/src/main/java/net/schmizz/sshj/signature/SignatureECDSA.java index 49a67768..0abe8ca8 100644 --- a/src/main/java/net/schmizz/sshj/signature/SignatureECDSA.java +++ b/src/main/java/net/schmizz/sshj/signature/SignatureECDSA.java @@ -15,13 +15,13 @@ */ package net.schmizz.sshj.signature; -import java.math.BigInteger; -import java.security.SignatureException; - import net.schmizz.sshj.common.Buffer; import net.schmizz.sshj.common.KeyType; import net.schmizz.sshj.common.SSHRuntimeException; +import java.math.BigInteger; +import java.security.SignatureException; + /** ECDSA {@link Signature} */ public class SignatureECDSA extends AbstractSignature { diff --git a/src/main/java/net/schmizz/sshj/signature/SignatureRSA.java b/src/main/java/net/schmizz/sshj/signature/SignatureRSA.java index 14758efa..6ed5f1bb 100644 --- a/src/main/java/net/schmizz/sshj/signature/SignatureRSA.java +++ b/src/main/java/net/schmizz/sshj/signature/SignatureRSA.java @@ -15,11 +15,11 @@ */ package net.schmizz.sshj.signature; -import java.security.SignatureException; - import net.schmizz.sshj.common.KeyType; import net.schmizz.sshj.common.SSHRuntimeException; +import java.security.SignatureException; + /** RSA {@link Signature} */ public class SignatureRSA extends AbstractSignature { diff --git a/src/main/java/net/schmizz/sshj/transport/Decoder.java b/src/main/java/net/schmizz/sshj/transport/Decoder.java index a67c2891..5cdb1564 100644 --- a/src/main/java/net/schmizz/sshj/transport/Decoder.java +++ b/src/main/java/net/schmizz/sshj/transport/Decoder.java @@ -15,12 +15,7 @@ */ package net.schmizz.sshj.transport; -import net.schmizz.sshj.common.Buffer; -import net.schmizz.sshj.common.ByteArrayUtils; -import net.schmizz.sshj.common.DisconnectReason; -import net.schmizz.sshj.common.SSHException; -import net.schmizz.sshj.common.SSHPacket; -import net.schmizz.sshj.common.SSHPacketHandler; +import net.schmizz.sshj.common.*; import net.schmizz.sshj.transport.cipher.Cipher; import net.schmizz.sshj.transport.compression.Compression; import net.schmizz.sshj.transport.mac.MAC; @@ -193,4 +188,4 @@ final class Decoder return MAX_PACKET_LEN; } -} \ No newline at end of file +} diff --git a/src/main/java/net/schmizz/sshj/transport/KeyExchanger.java b/src/main/java/net/schmizz/sshj/transport/KeyExchanger.java index 44ebf686..33f0422c 100644 --- a/src/main/java/net/schmizz/sshj/transport/KeyExchanger.java +++ b/src/main/java/net/schmizz/sshj/transport/KeyExchanger.java @@ -17,24 +17,14 @@ package net.schmizz.sshj.transport; import net.schmizz.concurrent.ErrorDeliveryUtil; import net.schmizz.concurrent.Event; -import net.schmizz.sshj.common.Buffer; -import net.schmizz.sshj.common.DisconnectReason; -import net.schmizz.sshj.common.ErrorNotifiable; -import net.schmizz.sshj.common.Factory; -import net.schmizz.sshj.common.KeyType; -import net.schmizz.sshj.common.Message; -import net.schmizz.sshj.common.SSHException; -import net.schmizz.sshj.common.SSHPacket; -import net.schmizz.sshj.common.SSHPacketHandler; -import net.schmizz.sshj.common.SecurityUtils; +import net.schmizz.sshj.common.*; import net.schmizz.sshj.transport.cipher.Cipher; import net.schmizz.sshj.transport.compression.Compression; import net.schmizz.sshj.transport.digest.Digest; import net.schmizz.sshj.transport.kex.KeyExchange; import net.schmizz.sshj.transport.mac.MAC; -import net.schmizz.sshj.transport.verification.HostKeyVerifier; import net.schmizz.sshj.transport.verification.AlgorithmsVerifier; - +import net.schmizz.sshj.transport.verification.HostKeyVerifier; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -395,4 +385,4 @@ final class KeyExchanger ErrorDeliveryUtil.alertEvents(error, kexInitSent, done); } -} \ No newline at end of file +} diff --git a/src/main/java/net/schmizz/sshj/transport/cipher/BaseCipher.java b/src/main/java/net/schmizz/sshj/transport/cipher/BaseCipher.java index 0dc5f1b9..6133b85a 100644 --- a/src/main/java/net/schmizz/sshj/transport/cipher/BaseCipher.java +++ b/src/main/java/net/schmizz/sshj/transport/cipher/BaseCipher.java @@ -19,7 +19,6 @@ import net.schmizz.sshj.common.SSHRuntimeException; import net.schmizz.sshj.common.SecurityUtils; import javax.crypto.ShortBufferException; -import javax.crypto.spec.IvParameterSpec; import javax.crypto.spec.SecretKeySpec; import java.security.GeneralSecurityException; import java.security.InvalidAlgorithmParameterException; diff --git a/src/main/java/net/schmizz/sshj/transport/kex/AbstractDH.java b/src/main/java/net/schmizz/sshj/transport/kex/AbstractDH.java index 49a70201..3f1d5bba 100644 --- a/src/main/java/net/schmizz/sshj/transport/kex/AbstractDH.java +++ b/src/main/java/net/schmizz/sshj/transport/kex/AbstractDH.java @@ -18,8 +18,6 @@ package net.schmizz.sshj.transport.kex; import net.schmizz.sshj.transport.digest.Digest; import java.math.BigInteger; -import java.security.PublicKey; -import java.util.Arrays; public abstract class AbstractDH extends KeyExchangeBase { protected final DHBase dh; diff --git a/src/main/java/net/schmizz/sshj/transport/kex/AbstractDHG.java b/src/main/java/net/schmizz/sshj/transport/kex/AbstractDHG.java index 067fd202..8556650f 100644 --- a/src/main/java/net/schmizz/sshj/transport/kex/AbstractDHG.java +++ b/src/main/java/net/schmizz/sshj/transport/kex/AbstractDHG.java @@ -15,24 +15,15 @@ */ package net.schmizz.sshj.transport.kex; -import net.schmizz.sshj.common.Buffer; -import net.schmizz.sshj.common.DisconnectReason; -import net.schmizz.sshj.common.Factory; -import net.schmizz.sshj.common.KeyType; -import net.schmizz.sshj.common.Message; -import net.schmizz.sshj.common.SSHPacket; +import net.schmizz.sshj.common.*; import net.schmizz.sshj.signature.Signature; import net.schmizz.sshj.transport.Transport; import net.schmizz.sshj.transport.TransportException; import net.schmizz.sshj.transport.digest.Digest; -import net.schmizz.sshj.transport.digest.SHA1; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import java.math.BigInteger; import java.security.GeneralSecurityException; -import java.security.PublicKey; -import java.util.Arrays; /** * Base class for DHG key exchange algorithms. Implementations will only have to configure the required data on the diff --git a/src/main/java/net/schmizz/sshj/transport/kex/Curve25519DH.java b/src/main/java/net/schmizz/sshj/transport/kex/Curve25519DH.java index 9a28b38e..b1deef4c 100644 --- a/src/main/java/net/schmizz/sshj/transport/kex/Curve25519DH.java +++ b/src/main/java/net/schmizz/sshj/transport/kex/Curve25519DH.java @@ -15,21 +15,15 @@ */ package net.schmizz.sshj.transport.kex; -import net.schmizz.sshj.common.SecurityUtils; import org.bouncycastle.asn1.x9.X9ECParameters; import org.bouncycastle.crypto.ec.CustomNamedCurves; import org.bouncycastle.jce.spec.ECParameterSpec; -import org.bouncycastle.math.ec.ECFieldElement; -import org.bouncycastle.math.ec.custom.djb.Curve25519; import java.math.BigInteger; -import java.security.*; -import java.security.interfaces.ECPublicKey; +import java.security.GeneralSecurityException; +import java.security.SecureRandom; import java.security.spec.AlgorithmParameterSpec; -import java.security.spec.ECPoint; -import java.security.spec.ECPublicKeySpec; import java.util.Arrays; -import java.util.BitSet; public class Curve25519DH extends DHBase { diff --git a/src/main/java/net/schmizz/sshj/transport/kex/Curve25519SHA256.java b/src/main/java/net/schmizz/sshj/transport/kex/Curve25519SHA256.java index 692ac07b..ebf1bcbb 100644 --- a/src/main/java/net/schmizz/sshj/transport/kex/Curve25519SHA256.java +++ b/src/main/java/net/schmizz/sshj/transport/kex/Curve25519SHA256.java @@ -15,9 +15,6 @@ */ package net.schmizz.sshj.transport.kex; -import net.schmizz.sshj.common.*; -import net.schmizz.sshj.signature.Signature; -import net.schmizz.sshj.transport.TransportException; import net.schmizz.sshj.transport.digest.SHA256; import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/src/main/java/net/schmizz/sshj/transport/kex/ECDH.java b/src/main/java/net/schmizz/sshj/transport/kex/ECDH.java index 63178ccf..2c5a74bf 100644 --- a/src/main/java/net/schmizz/sshj/transport/kex/ECDH.java +++ b/src/main/java/net/schmizz/sshj/transport/kex/ECDH.java @@ -23,7 +23,10 @@ import java.security.KeyFactory; import java.security.KeyPair; import java.security.PublicKey; import java.security.interfaces.ECPublicKey; -import java.security.spec.*; +import java.security.spec.AlgorithmParameterSpec; +import java.security.spec.ECParameterSpec; +import java.security.spec.ECPoint; +import java.security.spec.ECPublicKeySpec; import static com.hierynomus.sshj.secg.SecgUtils.getDecoded; import static com.hierynomus.sshj.secg.SecgUtils.getEncoded; diff --git a/src/main/java/net/schmizz/sshj/transport/verification/OpenSSHKnownHosts.java b/src/main/java/net/schmizz/sshj/transport/verification/OpenSSHKnownHosts.java index 78500b59..1a0204a6 100644 --- a/src/main/java/net/schmizz/sshj/transport/verification/OpenSSHKnownHosts.java +++ b/src/main/java/net/schmizz/sshj/transport/verification/OpenSSHKnownHosts.java @@ -15,25 +15,13 @@ */ package net.schmizz.sshj.transport.verification; -import net.schmizz.sshj.common.Base64; -import net.schmizz.sshj.common.Buffer; -import net.schmizz.sshj.common.IOUtils; -import net.schmizz.sshj.common.KeyType; -import net.schmizz.sshj.common.SSHException; -import net.schmizz.sshj.common.SecurityUtils; +import net.schmizz.sshj.common.*; import net.schmizz.sshj.transport.mac.HMACSHA1; import net.schmizz.sshj.transport.mac.MAC; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import java.io.BufferedOutputStream; -import java.io.BufferedReader; -import java.io.BufferedWriter; -import java.io.File; -import java.io.FileOutputStream; -import java.io.FileReader; -import java.io.FileWriter; -import java.io.IOException; +import java.io.*; import java.math.BigInteger; import java.security.KeyFactory; import java.security.PublicKey; @@ -461,14 +449,14 @@ public class OpenSSHKnownHosts public String getMarkerString() { return sMarker; } - + public static Marker fromString(String str) { for (Marker m: values()) if (m.sMarker.equals(str)) return m; return null; } - + } } diff --git a/src/main/java/net/schmizz/sshj/userauth/keyprovider/KeyProviderUtil.java b/src/main/java/net/schmizz/sshj/userauth/keyprovider/KeyProviderUtil.java index b6f8a8c4..41dc1d9a 100644 --- a/src/main/java/net/schmizz/sshj/userauth/keyprovider/KeyProviderUtil.java +++ b/src/main/java/net/schmizz/sshj/userauth/keyprovider/KeyProviderUtil.java @@ -15,15 +15,10 @@ */ package net.schmizz.sshj.userauth.keyprovider; -import java.io.BufferedReader; -import java.io.File; -import java.io.FileReader; -import java.io.IOException; -import java.io.Reader; -import java.io.StringReader; - import net.schmizz.sshj.common.IOUtils; +import java.io.*; + public class KeyProviderUtil { /** diff --git a/src/main/java/net/schmizz/sshj/userauth/keyprovider/OpenSSHKeyFile.java b/src/main/java/net/schmizz/sshj/userauth/keyprovider/OpenSSHKeyFile.java index f85e1a67..bf8f613e 100644 --- a/src/main/java/net/schmizz/sshj/userauth/keyprovider/OpenSSHKeyFile.java +++ b/src/main/java/net/schmizz/sshj/userauth/keyprovider/OpenSSHKeyFile.java @@ -19,12 +19,7 @@ import net.schmizz.sshj.common.Base64; import net.schmizz.sshj.common.Buffer; import net.schmizz.sshj.common.KeyType; -import java.io.BufferedReader; -import java.io.File; -import java.io.FileReader; -import java.io.IOException; -import java.io.Reader; -import java.io.StringReader; +import java.io.*; import java.security.PublicKey; diff --git a/src/main/java/net/schmizz/sshj/userauth/keyprovider/PKCS5KeyFile.java b/src/main/java/net/schmizz/sshj/userauth/keyprovider/PKCS5KeyFile.java index 736b78da..e1079135 100644 --- a/src/main/java/net/schmizz/sshj/userauth/keyprovider/PKCS5KeyFile.java +++ b/src/main/java/net/schmizz/sshj/userauth/keyprovider/PKCS5KeyFile.java @@ -18,41 +18,19 @@ package net.schmizz.sshj.userauth.keyprovider; import net.schmizz.sshj.common.Base64; import net.schmizz.sshj.common.IOUtils; import net.schmizz.sshj.common.KeyType; -import net.schmizz.sshj.transport.cipher.AES128CBC; -import net.schmizz.sshj.transport.cipher.AES192CBC; -import net.schmizz.sshj.transport.cipher.AES256CBC; -import net.schmizz.sshj.transport.cipher.Cipher; -import net.schmizz.sshj.transport.cipher.NoneCipher; -import net.schmizz.sshj.transport.cipher.TripleDESCBC; +import net.schmizz.sshj.transport.cipher.*; import net.schmizz.sshj.transport.digest.Digest; import net.schmizz.sshj.transport.digest.MD5; -import net.schmizz.sshj.userauth.password.PasswordFinder; -import net.schmizz.sshj.userauth.password.PasswordUtils; -import net.schmizz.sshj.userauth.password.PrivateKeyFileResource; -import net.schmizz.sshj.userauth.password.PrivateKeyReaderResource; -import net.schmizz.sshj.userauth.password.PrivateKeyStringResource; -import net.schmizz.sshj.userauth.password.Resource; +import net.schmizz.sshj.userauth.password.*; -import java.io.BufferedReader; -import java.io.File; -import java.io.EOFException; -import java.io.IOException; -import java.io.Reader; +import javax.xml.bind.DatatypeConverter; +import java.io.*; import java.math.BigInteger; import java.nio.ByteBuffer; import java.nio.CharBuffer; -import java.security.KeyFactory; -import java.security.KeyPair; -import java.security.NoSuchAlgorithmException; -import java.security.PrivateKey; -import java.security.PublicKey; -import java.security.spec.DSAPrivateKeySpec; -import java.security.spec.DSAPublicKeySpec; -import java.security.spec.InvalidKeySpecException; -import java.security.spec.RSAPrivateKeySpec; -import java.security.spec.RSAPublicKeySpec; +import java.security.*; +import java.security.spec.*; import java.util.Arrays; -import javax.xml.bind.DatatypeConverter; /** Represents a PKCS5-encoded key file. This is the format typically used by OpenSSH, OpenSSL, Amazon, etc. */ public class PKCS5KeyFile diff --git a/src/main/java/net/schmizz/sshj/userauth/keyprovider/PKCS8KeyFile.java b/src/main/java/net/schmizz/sshj/userauth/keyprovider/PKCS8KeyFile.java index 097490d0..b72e6ba7 100644 --- a/src/main/java/net/schmizz/sshj/userauth/keyprovider/PKCS8KeyFile.java +++ b/src/main/java/net/schmizz/sshj/userauth/keyprovider/PKCS8KeyFile.java @@ -17,12 +17,7 @@ package net.schmizz.sshj.userauth.keyprovider; import net.schmizz.sshj.common.IOUtils; import net.schmizz.sshj.common.KeyType; -import net.schmizz.sshj.userauth.password.PasswordFinder; -import net.schmizz.sshj.userauth.password.PasswordUtils; -import net.schmizz.sshj.userauth.password.PrivateKeyFileResource; -import net.schmizz.sshj.userauth.password.PrivateKeyReaderResource; -import net.schmizz.sshj.userauth.password.PrivateKeyStringResource; -import net.schmizz.sshj.userauth.password.Resource; +import net.schmizz.sshj.userauth.password.*; import org.bouncycastle.openssl.EncryptionException; import org.bouncycastle.openssl.PEMEncryptedKeyPair; import org.bouncycastle.openssl.PEMKeyPair; @@ -170,4 +165,4 @@ public class PKCS8KeyFile public String toString() { return "PKCS8KeyFile{resource=" + resource + "}"; } -} \ No newline at end of file +} diff --git a/src/main/java/net/schmizz/sshj/userauth/keyprovider/PuTTYKeyFile.java b/src/main/java/net/schmizz/sshj/userauth/keyprovider/PuTTYKeyFile.java index 84fcfedb..80728e83 100644 --- a/src/main/java/net/schmizz/sshj/userauth/keyprovider/PuTTYKeyFile.java +++ b/src/main/java/net/schmizz/sshj/userauth/keyprovider/PuTTYKeyFile.java @@ -15,46 +15,22 @@ */ package net.schmizz.sshj.userauth.keyprovider; +import net.schmizz.sshj.common.Base64; +import net.schmizz.sshj.common.KeyType; +import net.schmizz.sshj.userauth.password.*; import org.bouncycastle.util.encoders.Hex; import javax.crypto.Cipher; import javax.crypto.Mac; import javax.crypto.spec.IvParameterSpec; import javax.crypto.spec.SecretKeySpec; -import java.io.BufferedReader; -import java.io.ByteArrayInputStream; -import java.io.ByteArrayOutputStream; -import java.io.DataInput; -import java.io.DataInputStream; -import java.io.DataOutputStream; -import java.io.File; -import java.io.IOException; -import java.io.Reader; +import java.io.*; import java.math.BigInteger; -import java.security.GeneralSecurityException; -import java.security.KeyFactory; -import java.security.KeyPair; -import java.security.MessageDigest; -import java.security.NoSuchAlgorithmException; -import java.security.PrivateKey; -import java.security.PublicKey; -import java.security.spec.DSAPrivateKeySpec; -import java.security.spec.DSAPublicKeySpec; -import java.security.spec.InvalidKeySpecException; -import java.security.spec.RSAPrivateKeySpec; -import java.security.spec.RSAPublicKeySpec; +import java.security.*; +import java.security.spec.*; import java.util.HashMap; import java.util.Map; -import net.schmizz.sshj.common.Base64; -import net.schmizz.sshj.common.KeyType; -import net.schmizz.sshj.userauth.password.PasswordFinder; -import net.schmizz.sshj.userauth.password.PasswordUtils; -import net.schmizz.sshj.userauth.password.PrivateKeyFileResource; -import net.schmizz.sshj.userauth.password.PrivateKeyReaderResource; -import net.schmizz.sshj.userauth.password.PrivateKeyStringResource; -import net.schmizz.sshj.userauth.password.Resource; - /** *
@@ -423,4 +399,4 @@ public class PuTTYKeyFile implements FileKeyProvider {
return new BigInteger(read());
}
}
-}
\ No newline at end of file
+}
diff --git a/src/main/java/net/schmizz/sshj/userauth/method/AuthGssApiWithMic.java b/src/main/java/net/schmizz/sshj/userauth/method/AuthGssApiWithMic.java
index 751ebeca..e9facf3f 100644
--- a/src/main/java/net/schmizz/sshj/userauth/method/AuthGssApiWithMic.java
+++ b/src/main/java/net/schmizz/sshj/userauth/method/AuthGssApiWithMic.java
@@ -15,26 +15,19 @@
*/
package net.schmizz.sshj.userauth.method;
-import java.security.PrivilegedActionException;
-import java.security.PrivilegedExceptionAction;
-import java.util.List;
-
-import javax.security.auth.Subject;
-import javax.security.auth.login.LoginContext;
-
-import org.ietf.jgss.GSSContext;
-import org.ietf.jgss.GSSCredential;
-import org.ietf.jgss.GSSException;
-import org.ietf.jgss.GSSManager;
-import org.ietf.jgss.GSSName;
-import org.ietf.jgss.Oid;
-
import net.schmizz.sshj.common.Buffer.BufferException;
import net.schmizz.sshj.common.Buffer.PlainBuffer;
import net.schmizz.sshj.common.Message;
import net.schmizz.sshj.common.SSHPacket;
import net.schmizz.sshj.transport.TransportException;
import net.schmizz.sshj.userauth.UserAuthException;
+import org.ietf.jgss.*;
+
+import javax.security.auth.Subject;
+import javax.security.auth.login.LoginContext;
+import java.security.PrivilegedActionException;
+import java.security.PrivilegedExceptionAction;
+import java.util.List;
/** Implements authentication by GSS-API. */
public class AuthGssApiWithMic
diff --git a/src/main/java/net/schmizz/sshj/userauth/method/AuthPassword.java b/src/main/java/net/schmizz/sshj/userauth/method/AuthPassword.java
index e6cc028c..630cb9bb 100644
--- a/src/main/java/net/schmizz/sshj/userauth/method/AuthPassword.java
+++ b/src/main/java/net/schmizz/sshj/userauth/method/AuthPassword.java
@@ -25,8 +25,6 @@ import net.schmizz.sshj.userauth.password.PasswordFinder;
import net.schmizz.sshj.userauth.password.PasswordUpdateProvider;
import net.schmizz.sshj.userauth.password.Resource;
-import static net.schmizz.sshj.common.Message.USERAUTH_REQUEST;
-
/** Implements the {@code password} authentication method. Password-change request handling is not currently supported. */
public class AuthPassword
extends AbstractAuthMethod {
diff --git a/src/main/java/net/schmizz/sshj/userauth/password/PrivateKeyFileResource.java b/src/main/java/net/schmizz/sshj/userauth/password/PrivateKeyFileResource.java
index 78ba6c10..e0af491b 100644
--- a/src/main/java/net/schmizz/sshj/userauth/password/PrivateKeyFileResource.java
+++ b/src/main/java/net/schmizz/sshj/userauth/password/PrivateKeyFileResource.java
@@ -15,11 +15,7 @@
*/
package net.schmizz.sshj.userauth.password;
-import java.io.File;
-import java.io.FileInputStream;
-import java.io.IOException;
-import java.io.InputStreamReader;
-import java.io.Reader;
+import java.io.*;
public class PrivateKeyFileResource
extends Resource {
diff --git a/src/main/java/net/schmizz/sshj/xfer/FileSystemFile.java b/src/main/java/net/schmizz/sshj/xfer/FileSystemFile.java
index e15a46a3..642fc11f 100644
--- a/src/main/java/net/schmizz/sshj/xfer/FileSystemFile.java
+++ b/src/main/java/net/schmizz/sshj/xfer/FileSystemFile.java
@@ -18,13 +18,7 @@ package net.schmizz.sshj.xfer;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import java.io.File;
-import java.io.FileFilter;
-import java.io.FileInputStream;
-import java.io.FileOutputStream;
-import java.io.IOException;
-import java.io.InputStream;
-import java.io.OutputStream;
+import java.io.*;
import java.util.ArrayList;
import java.util.List;
diff --git a/src/main/java/net/schmizz/sshj/xfer/scp/SCPEngine.java b/src/main/java/net/schmizz/sshj/xfer/scp/SCPEngine.java
index 71096349..a3494b16 100644
--- a/src/main/java/net/schmizz/sshj/xfer/scp/SCPEngine.java
+++ b/src/main/java/net/schmizz/sshj/xfer/scp/SCPEngine.java
@@ -28,9 +28,6 @@ import java.io.ByteArrayOutputStream;
import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;
-import java.util.LinkedHashMap;
-import java.util.LinkedList;
-import java.util.List;
/** @see SCP Protocol */
class SCPEngine {
diff --git a/src/main/java/net/schmizz/sshj/xfer/scp/SCPFileTransfer.java b/src/main/java/net/schmizz/sshj/xfer/scp/SCPFileTransfer.java
index 1fa1c82c..38282cfa 100644
--- a/src/main/java/net/schmizz/sshj/xfer/scp/SCPFileTransfer.java
+++ b/src/main/java/net/schmizz/sshj/xfer/scp/SCPFileTransfer.java
@@ -16,11 +16,7 @@
package net.schmizz.sshj.xfer.scp;
import net.schmizz.sshj.connection.channel.direct.SessionFactory;
-import net.schmizz.sshj.xfer.AbstractFileTransfer;
-import net.schmizz.sshj.xfer.FileSystemFile;
-import net.schmizz.sshj.xfer.FileTransfer;
-import net.schmizz.sshj.xfer.LocalDestFile;
-import net.schmizz.sshj.xfer.LocalSourceFile;
+import net.schmizz.sshj.xfer.*;
import java.io.IOException;
diff --git a/src/test/java/com/hierynomus/sshj/connection/channel/forwarded/RemotePortForwarderTest.java b/src/test/java/com/hierynomus/sshj/connection/channel/forwarded/RemotePortForwarderTest.java
index 2277d4fa..c9bf1b8e 100644
--- a/src/test/java/com/hierynomus/sshj/connection/channel/forwarded/RemotePortForwarderTest.java
+++ b/src/test/java/com/hierynomus/sshj/connection/channel/forwarded/RemotePortForwarderTest.java
@@ -19,7 +19,6 @@ import com.hierynomus.sshj.test.HttpServer;
import com.hierynomus.sshj.test.SshFixture;
import com.hierynomus.sshj.test.util.FileUtil;
import net.schmizz.sshj.SSHClient;
-import net.schmizz.sshj.connection.Connection;
import net.schmizz.sshj.connection.ConnectionException;
import net.schmizz.sshj.connection.channel.forwarded.RemotePortForwarder;
import net.schmizz.sshj.connection.channel.forwarded.SocketForwardingConnectListener;
@@ -34,9 +33,7 @@ import org.junit.Test;
import java.io.File;
import java.io.IOException;
-import java.net.ConnectException;
import java.net.InetSocketAddress;
-import java.util.concurrent.atomic.AtomicInteger;
import static org.hamcrest.CoreMatchers.equalTo;
import static org.junit.Assert.assertThat;
diff --git a/src/test/java/com/hierynomus/sshj/test/HttpServer.java b/src/test/java/com/hierynomus/sshj/test/HttpServer.java
index 5d02adf8..7bdd0101 100644
--- a/src/test/java/com/hierynomus/sshj/test/HttpServer.java
+++ b/src/test/java/com/hierynomus/sshj/test/HttpServer.java
@@ -18,8 +18,6 @@ package com.hierynomus.sshj.test;
import org.junit.rules.ExternalResource;
import org.junit.rules.TemporaryFolder;
-import java.io.File;
-
/**
* Can be used to setup a test HTTP server
*/
diff --git a/src/test/java/com/hierynomus/sshj/transport/kex/KeyExchangeTest.java b/src/test/java/com/hierynomus/sshj/transport/kex/KeyExchangeTest.java
index f517a407..ad68318b 100644
--- a/src/test/java/com/hierynomus/sshj/transport/kex/KeyExchangeTest.java
+++ b/src/test/java/com/hierynomus/sshj/transport/kex/KeyExchangeTest.java
@@ -28,18 +28,13 @@ import org.apache.sshd.common.kex.KeyExchange;
import org.apache.sshd.server.SshServer;
import org.apache.sshd.server.kex.DHGEXServer;
import org.apache.sshd.server.kex.DHGServer;
-import org.junit.Ignore;
-import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
-import java.io.IOException;
import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
-import static org.hamcrest.MatcherAssert.assertThat;
-
@RunWith(Parameterized.class)
public class KeyExchangeTest extends BaseAlgorithmTest {
diff --git a/src/test/java/net/schmizz/sshj/common/BufferTest.java b/src/test/java/net/schmizz/sshj/common/BufferTest.java
index f142a4e3..1395bdd4 100644
--- a/src/test/java/net/schmizz/sshj/common/BufferTest.java
+++ b/src/test/java/net/schmizz/sshj/common/BufferTest.java
@@ -15,12 +15,11 @@
*/
package net.schmizz.sshj.common;
-import static org.junit.Assert.fail;
-
import net.schmizz.sshj.common.Buffer.PlainBuffer;
-
import org.junit.Test;
+import static org.junit.Assert.fail;
+
public class BufferTest {
// Issue 72: previously, it entered an infinite loop trying to establish the buffer size
diff --git a/src/test/java/net/schmizz/sshj/keyprovider/KeyProviderUtilTest.java b/src/test/java/net/schmizz/sshj/keyprovider/KeyProviderUtilTest.java
index 36a8d345..a35bee77 100644
--- a/src/test/java/net/schmizz/sshj/keyprovider/KeyProviderUtilTest.java
+++ b/src/test/java/net/schmizz/sshj/keyprovider/KeyProviderUtilTest.java
@@ -15,15 +15,14 @@
*/
package net.schmizz.sshj.keyprovider;
-import static org.junit.Assert.assertEquals;
+import net.schmizz.sshj.userauth.keyprovider.KeyFormat;
+import net.schmizz.sshj.userauth.keyprovider.KeyProviderUtil;
+import org.junit.Test;
import java.io.File;
import java.io.IOException;
-import org.junit.Test;
-
-import net.schmizz.sshj.userauth.keyprovider.KeyFormat;
-import net.schmizz.sshj.userauth.keyprovider.KeyProviderUtil;
+import static org.junit.Assert.assertEquals;
public class KeyProviderUtilTest {
diff --git a/src/test/java/net/schmizz/sshj/keyprovider/PuTTYKeyFileTest.java b/src/test/java/net/schmizz/sshj/keyprovider/PuTTYKeyFileTest.java
index 19b25389..88e7809d 100644
--- a/src/test/java/net/schmizz/sshj/keyprovider/PuTTYKeyFileTest.java
+++ b/src/test/java/net/schmizz/sshj/keyprovider/PuTTYKeyFileTest.java
@@ -15,15 +15,14 @@
*/
package net.schmizz.sshj.keyprovider;
+import net.schmizz.sshj.userauth.keyprovider.PuTTYKeyFile;
+import net.schmizz.sshj.userauth.password.PasswordFinder;
+import net.schmizz.sshj.userauth.password.Resource;
import org.junit.Test;
import java.io.IOException;
import java.io.StringReader;
-import net.schmizz.sshj.userauth.keyprovider.PuTTYKeyFile;
-import net.schmizz.sshj.userauth.password.PasswordFinder;
-import net.schmizz.sshj.userauth.password.Resource;
-
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull;
diff --git a/src/test/java/net/schmizz/sshj/sftp/PacketReaderTest.java b/src/test/java/net/schmizz/sshj/sftp/PacketReaderTest.java
index ff78618c..37507f1d 100644
--- a/src/test/java/net/schmizz/sshj/sftp/PacketReaderTest.java
+++ b/src/test/java/net/schmizz/sshj/sftp/PacketReaderTest.java
@@ -15,21 +15,18 @@
*/
package net.schmizz.sshj.sftp;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertTrue;
-import static org.junit.Assert.fail;
+import net.schmizz.sshj.common.SSHException;
+import net.schmizz.sshj.connection.channel.direct.Session.Subsystem;
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.Mockito;
import java.io.DataOutputStream;
import java.io.PipedInputStream;
import java.io.PipedOutputStream;
import java.util.Arrays;
-import net.schmizz.sshj.common.SSHException;
-import net.schmizz.sshj.connection.channel.direct.Session.Subsystem;
-
-import org.junit.Before;
-import org.junit.Test;
-import org.mockito.Mockito;
+import static org.junit.Assert.*;
public class PacketReaderTest {
@@ -59,7 +56,7 @@ public class PacketReaderTest {
dataout.writeInt(10);
dataout.write(bytes);
dataout.flush();
-
+
SFTPPacket packet = reader.readPacket();
assertEquals(packet.available(), 10);
assertTrue("actual=" + Arrays.toString(packet.array()), Arrays.equals(bytes, subArray(packet.array(), 0, 10)));
@@ -69,7 +66,7 @@ public class PacketReaderTest {
public void shouldFailWhenPacketLengthTooLarge() throws Exception {
dataout.writeInt(Integer.MAX_VALUE);
dataout.flush();
-
+
try {
reader.readPacket();
fail("Should have failed to read packet of size " + Integer.MAX_VALUE);
diff --git a/src/test/java/net/schmizz/sshj/sftp/SFTPClientTest.java b/src/test/java/net/schmizz/sshj/sftp/SFTPClientTest.java
index 72346cdf..349f0eec 100644
--- a/src/test/java/net/schmizz/sshj/sftp/SFTPClientTest.java
+++ b/src/test/java/net/schmizz/sshj/sftp/SFTPClientTest.java
@@ -21,10 +21,7 @@ import org.junit.Test;
import java.io.IOException;
import static net.schmizz.sshj.sftp.PathHelper.DEFAULT_PATH_SEPARATOR;
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.times;
-import static org.mockito.Mockito.verify;
-import static org.mockito.Mockito.when;
+import static org.mockito.Mockito.*;
public class SFTPClientTest {
private final SFTPEngine sftpEngine = mock(SFTPEngine.class);
@@ -55,4 +52,4 @@ public class SFTPClientTest {
client.mkdirs("/folder/directory/");
verify(sftpEngine, times(1)).makeDir("/folder/directory");
}
-}
\ No newline at end of file
+}
diff --git a/src/test/java/net/schmizz/sshj/transport/mac/HMACMD596Test.java b/src/test/java/net/schmizz/sshj/transport/mac/HMACMD596Test.java
index 0f34024a..abb49476 100644
--- a/src/test/java/net/schmizz/sshj/transport/mac/HMACMD596Test.java
+++ b/src/test/java/net/schmizz/sshj/transport/mac/HMACMD596Test.java
@@ -16,7 +16,6 @@
package net.schmizz.sshj.transport.mac;
import org.bouncycastle.util.encoders.Hex;
-import org.junit.Ignore;
import org.junit.Test;
import java.nio.charset.Charset;
@@ -57,4 +56,4 @@ public class HMACMD596Test {
hmac.init("ohBahfei6pee5dai".getBytes(CHARSET));
return hmac;
}
-}
\ No newline at end of file
+}
diff --git a/src/test/java/net/schmizz/sshj/transport/mac/HMACMD5Test.java b/src/test/java/net/schmizz/sshj/transport/mac/HMACMD5Test.java
index e7b545b8..adb35f9f 100644
--- a/src/test/java/net/schmizz/sshj/transport/mac/HMACMD5Test.java
+++ b/src/test/java/net/schmizz/sshj/transport/mac/HMACMD5Test.java
@@ -16,7 +16,6 @@
package net.schmizz.sshj.transport.mac;
import org.bouncycastle.util.encoders.Hex;
-import org.junit.Ignore;
import org.junit.Test;
import java.nio.charset.Charset;
@@ -56,4 +55,4 @@ public class HMACMD5Test {
hmac.init("ohBahfei6pee5dai".getBytes(CHARSET));
return hmac;
}
-}
\ No newline at end of file
+}
diff --git a/src/test/java/net/schmizz/sshj/transport/mac/HMACSHA196Test.java b/src/test/java/net/schmizz/sshj/transport/mac/HMACSHA196Test.java
index fffee1af..8c3d5623 100644
--- a/src/test/java/net/schmizz/sshj/transport/mac/HMACSHA196Test.java
+++ b/src/test/java/net/schmizz/sshj/transport/mac/HMACSHA196Test.java
@@ -16,7 +16,6 @@
package net.schmizz.sshj.transport.mac;
import org.bouncycastle.util.encoders.Hex;
-import org.junit.Ignore;
import org.junit.Test;
import java.nio.charset.Charset;
@@ -56,4 +55,4 @@ public class HMACSHA196Test {
hmac.init("et1Quo5ooCie6theel8i".getBytes(CHARSET));
return hmac;
}
-}
\ No newline at end of file
+}
diff --git a/src/test/java/net/schmizz/sshj/transport/mac/HMACSHA2512Test.java b/src/test/java/net/schmizz/sshj/transport/mac/HMACSHA2512Test.java
index 5c5973ed..39deccbd 100644
--- a/src/test/java/net/schmizz/sshj/transport/mac/HMACSHA2512Test.java
+++ b/src/test/java/net/schmizz/sshj/transport/mac/HMACSHA2512Test.java
@@ -20,8 +20,8 @@ import org.junit.Test;
import java.nio.charset.Charset;
-import static org.junit.Assert.assertThat;
import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.assertThat;
public class HMACSHA2512Test {
private static final Charset CHARSET = Charset.forName("US-ASCII");
@@ -55,4 +55,4 @@ public class HMACSHA2512Test {
hmac.init("paishiengu1jaeTie5OoTu2eib7Kohqueicie7ahLohfoothahpeivi5weik1EiB".getBytes(CHARSET));
return hmac;
}
-}
\ No newline at end of file
+}
diff --git a/src/test/java/net/schmizz/sshj/transport/verification/OpenSSHKnownHostsTest.java b/src/test/java/net/schmizz/sshj/transport/verification/OpenSSHKnownHostsTest.java
index 4559f4e7..7bd4a7b4 100644
--- a/src/test/java/net/schmizz/sshj/transport/verification/OpenSSHKnownHostsTest.java
+++ b/src/test/java/net/schmizz/sshj/transport/verification/OpenSSHKnownHostsTest.java
@@ -29,9 +29,7 @@ import java.security.PublicKey;
import static org.hamcrest.CoreMatchers.equalTo;
import static org.hamcrest.CoreMatchers.instanceOf;
-import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertThat;
-import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.*;
public class OpenSSHKnownHostsTest {
diff --git a/src/test/java/net/schmizz/sshj/util/gss/BogusGSSContext.java b/src/test/java/net/schmizz/sshj/util/gss/BogusGSSContext.java
index bc6c9d8e..8f650756 100644
--- a/src/test/java/net/schmizz/sshj/util/gss/BogusGSSContext.java
+++ b/src/test/java/net/schmizz/sshj/util/gss/BogusGSSContext.java
@@ -15,7 +15,7 @@
*/
package net.schmizz.sshj.util.gss;
-import static net.schmizz.sshj.util.gss.BogusGSSManager.unavailable;
+import org.ietf.jgss.*;
import java.io.InputStream;
import java.io.OutputStream;
@@ -24,13 +24,7 @@ import java.net.UnknownHostException;
import java.nio.charset.Charset;
import java.util.Arrays;
-import org.ietf.jgss.ChannelBinding;
-import org.ietf.jgss.GSSContext;
-import org.ietf.jgss.GSSCredential;
-import org.ietf.jgss.GSSException;
-import org.ietf.jgss.GSSName;
-import org.ietf.jgss.MessageProp;
-import org.ietf.jgss.Oid;
+import static net.schmizz.sshj.util.gss.BogusGSSManager.unavailable;
public class BogusGSSContext
implements GSSContext {
diff --git a/src/test/java/net/schmizz/sshj/util/gss/BogusGSSCredential.java b/src/test/java/net/schmizz/sshj/util/gss/BogusGSSCredential.java
index e653697b..a211b5ca 100644
--- a/src/test/java/net/schmizz/sshj/util/gss/BogusGSSCredential.java
+++ b/src/test/java/net/schmizz/sshj/util/gss/BogusGSSCredential.java
@@ -15,13 +15,13 @@
*/
package net.schmizz.sshj.util.gss;
-import static net.schmizz.sshj.util.gss.BogusGSSManager.unavailable;
-
import org.ietf.jgss.GSSCredential;
import org.ietf.jgss.GSSException;
import org.ietf.jgss.GSSName;
import org.ietf.jgss.Oid;
+import static net.schmizz.sshj.util.gss.BogusGSSManager.unavailable;
+
public class BogusGSSCredential
implements GSSCredential {
diff --git a/src/test/java/net/schmizz/sshj/util/gss/BogusGSSManager.java b/src/test/java/net/schmizz/sshj/util/gss/BogusGSSManager.java
index e38e0002..0ccd3198 100644
--- a/src/test/java/net/schmizz/sshj/util/gss/BogusGSSManager.java
+++ b/src/test/java/net/schmizz/sshj/util/gss/BogusGSSManager.java
@@ -15,18 +15,13 @@
*/
package net.schmizz.sshj.util.gss;
-import java.security.Provider;
-
import org.apache.sshd.server.auth.gss.UserAuthGSS;
-import org.ietf.jgss.GSSContext;
-import org.ietf.jgss.GSSCredential;
-import org.ietf.jgss.GSSException;
-import org.ietf.jgss.GSSManager;
-import org.ietf.jgss.GSSName;
-import org.ietf.jgss.Oid;
+import org.ietf.jgss.*;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import java.security.Provider;
+
/**
* Implements a fake Kerberos 5 mechanism. MINA only supports Kerberos 5 over
* GSS-API, so we can't implement a separate mechanism.
@@ -118,4 +113,4 @@ public class BogusGSSManager
log.error(e.getMessage(), e);
throw e;
}
-}
\ No newline at end of file
+}
diff --git a/src/test/java/net/schmizz/sshj/util/gss/BogusGSSName.java b/src/test/java/net/schmizz/sshj/util/gss/BogusGSSName.java
index f91b5da7..1440cbb5 100644
--- a/src/test/java/net/schmizz/sshj/util/gss/BogusGSSName.java
+++ b/src/test/java/net/schmizz/sshj/util/gss/BogusGSSName.java
@@ -15,12 +15,12 @@
*/
package net.schmizz.sshj.util.gss;
-import static net.schmizz.sshj.util.gss.BogusGSSManager.unavailable;
-
import org.ietf.jgss.GSSException;
import org.ietf.jgss.GSSName;
import org.ietf.jgss.Oid;
+import static net.schmizz.sshj.util.gss.BogusGSSManager.unavailable;
+
public class BogusGSSName
implements GSSName {