From a3b6fde44a66b795ecd6c56956124186236773fb Mon Sep 17 00:00:00 2001 From: Shikhar Bhushan Date: Wed, 16 Jun 2010 23:52:24 +0100 Subject: [PATCH] useless params, useless check, overkill... --- src/main/java/net/schmizz/sshj/SSHClient.java | 10 ++++------ src/test/java/net/schmizz/sshj/SmokeTest.java | 2 +- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/main/java/net/schmizz/sshj/SSHClient.java b/src/main/java/net/schmizz/sshj/SSHClient.java index 8f4057d7..e6e983f9 100644 --- a/src/main/java/net/schmizz/sshj/SSHClient.java +++ b/src/main/java/net/schmizz/sshj/SSHClient.java @@ -156,20 +156,18 @@ public class SSHClient } /** - * Add a {@link HostKeyVerifier} that will verify any host at given {@code hostname:port} and a host key that has - * the given {@code fingerprint}, e.g. {@code "4b:69:6c:72:6f:79:20:77:61:73:20:68:65:72:65:21"} + * Add a {@link HostKeyVerifier} that will verify any host that's able to claim a host key with the given {@code + * fingerprint}, e.g. {@code "4b:69:6c:72:6f:79:20:77:61:73:20:68:65:72:65:21"} * - * @param host the hostname / IP address - * @param port the port for which the {@code fingerprint} applies * @param fingerprint expected fingerprint in colon-delimited format (16 octets in hex delimited by a colon) * * @see SecurityUtils#getFingerprint */ - public void addHostKeyVerifier(final String host, final int port, final String fingerprint) { + public void addHostKeyVerifier(final String fingerprint) { addHostKeyVerifier(new HostKeyVerifier() { @Override public boolean verify(String h, int p, PublicKey k) { - return host.equals(h) && port == p && SecurityUtils.getFingerprint(k).equals(fingerprint); + return SecurityUtils.getFingerprint(k).equals(fingerprint); } }); } diff --git a/src/test/java/net/schmizz/sshj/SmokeTest.java b/src/test/java/net/schmizz/sshj/SmokeTest.java index 07684a66..e1f5a356 100644 --- a/src/test/java/net/schmizz/sshj/SmokeTest.java +++ b/src/test/java/net/schmizz/sshj/SmokeTest.java @@ -57,7 +57,7 @@ public class SmokeTest { sshd.start(); ssh = new SSHClient(); - ssh.addHostKeyVerifier(hostname, port, fingerprint); + ssh.addHostKeyVerifier(fingerprint); } @After