useless params, useless check, overkill...

This commit is contained in:
Shikhar Bhushan
2010-06-16 23:52:24 +01:00
parent 69555e9c74
commit a3b6fde44a
2 changed files with 5 additions and 7 deletions

View File

@@ -156,20 +156,18 @@ public class SSHClient
} }
/** /**
* Add a {@link HostKeyVerifier} that will verify any host at given {@code hostname:port} and a host key that has * Add a {@link HostKeyVerifier} that will verify any host that's able to claim a host key with the given {@code
* the given {@code fingerprint}, e.g. {@code "4b:69:6c:72:6f:79:20:77:61:73:20:68:65:72:65:21"} * fingerprint}, e.g. {@code "4b:69:6c:72:6f:79:20:77:61:73:20:68:65:72:65:21"}
* *
* @param host the hostname / IP address
* @param port the port for which the {@code fingerprint} applies
* @param fingerprint expected fingerprint in colon-delimited format (16 octets in hex delimited by a colon) * @param fingerprint expected fingerprint in colon-delimited format (16 octets in hex delimited by a colon)
* *
* @see SecurityUtils#getFingerprint * @see SecurityUtils#getFingerprint
*/ */
public void addHostKeyVerifier(final String host, final int port, final String fingerprint) { public void addHostKeyVerifier(final String fingerprint) {
addHostKeyVerifier(new HostKeyVerifier() { addHostKeyVerifier(new HostKeyVerifier() {
@Override @Override
public boolean verify(String h, int p, PublicKey k) { public boolean verify(String h, int p, PublicKey k) {
return host.equals(h) && port == p && SecurityUtils.getFingerprint(k).equals(fingerprint); return SecurityUtils.getFingerprint(k).equals(fingerprint);
} }
}); });
} }

View File

@@ -57,7 +57,7 @@ public class SmokeTest {
sshd.start(); sshd.start();
ssh = new SSHClient(); ssh = new SSHClient();
ssh.addHostKeyVerifier(hostname, port, fingerprint); ssh.addHostKeyVerifier(fingerprint);
} }
@After @After