diff --git a/src/main/java/net/schmizz/sshj/transport/Encoder.java b/src/main/java/net/schmizz/sshj/transport/Encoder.java index 58bd5800..c5831718 100644 --- a/src/main/java/net/schmizz/sshj/transport/Encoder.java +++ b/src/main/java/net/schmizz/sshj/transport/Encoder.java @@ -39,19 +39,6 @@ final class Encoder log = loggerFactory.getLogger(getClass()); } - private SSHPacket checkHeaderSpace(SSHPacket buffer) { - if (buffer.rpos() < 5) { - log.warn("Performance cost: when sending a packet, ensure that " - + "5 bytes are available in front of the buffer"); - SSHPacket nb = new SSHPacket(buffer.available() + 5); - nb.rpos(5); - nb.wpos(5); - nb.putBuffer(buffer); - buffer = nb; - } - return buffer; - } - private void compress(SSHPacket buffer) { compression.compress(buffer); } diff --git a/src/main/java/net/schmizz/sshj/transport/kex/Curve25519SHA256.java b/src/main/java/net/schmizz/sshj/transport/kex/Curve25519SHA256.java index 92f4461c..61bb42f7 100644 --- a/src/main/java/net/schmizz/sshj/transport/kex/Curve25519SHA256.java +++ b/src/main/java/net/schmizz/sshj/transport/kex/Curve25519SHA256.java @@ -16,14 +16,10 @@ package net.schmizz.sshj.transport.kex; import net.schmizz.sshj.transport.digest.SHA256; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; import java.security.GeneralSecurityException; public class Curve25519SHA256 extends AbstractDHG { - private static final Logger logger = LoggerFactory.getLogger(Curve25519SHA256.class); - /** Named factory for Curve25519SHA256 key exchange */ public static class Factory implements net.schmizz.sshj.common.Factory.Named { diff --git a/src/test/java/com/hierynomus/sshj/connection/channel/forwarded/RemotePortForwarderTest.java b/src/test/java/com/hierynomus/sshj/connection/channel/forwarded/RemotePortForwarderTest.java index c9bf1b8e..c6b77c5d 100644 --- a/src/test/java/com/hierynomus/sshj/connection/channel/forwarded/RemotePortForwarderTest.java +++ b/src/test/java/com/hierynomus/sshj/connection/channel/forwarded/RemotePortForwarderTest.java @@ -40,11 +40,6 @@ import static org.junit.Assert.assertThat; public class RemotePortForwarderTest { - // Credentials for an remote SSH Server to test against. - private static final String REMOTE_HOST = "x.x.x.x"; - private static final String USER = "xxxx"; - private static final String PASSWORD = "yyyy"; - private static final PortRange RANGE = new PortRange(9000, 9999); private static final InetSocketAddress HTTP_SERVER_SOCKET_ADDR = new InetSocketAddress("127.0.0.1", 8080); diff --git a/src/test/java/com/hierynomus/sshj/test/HttpServer.java b/src/test/java/com/hierynomus/sshj/test/HttpServer.java index 7bdd0101..76ec2333 100644 --- a/src/test/java/com/hierynomus/sshj/test/HttpServer.java +++ b/src/test/java/com/hierynomus/sshj/test/HttpServer.java @@ -27,9 +27,6 @@ public class HttpServer extends ExternalResource { private TemporaryFolder docRoot = new TemporaryFolder(); - public HttpServer() { - } - @Override protected void before() throws Throwable { docRoot.create(); diff --git a/src/test/java/net/schmizz/sshj/sftp/PacketReaderTest.java b/src/test/java/net/schmizz/sshj/sftp/PacketReaderTest.java index 234a520e..63b12819 100644 --- a/src/test/java/net/schmizz/sshj/sftp/PacketReaderTest.java +++ b/src/test/java/net/schmizz/sshj/sftp/PacketReaderTest.java @@ -33,8 +33,6 @@ public class PacketReaderTest { private DataOutputStream dataout; private PacketReader reader; - private SFTPEngine engine; - private Subsystem subsystem; @Before public void setUp() throws Exception { @@ -42,8 +40,8 @@ public class PacketReaderTest { PipedInputStream pipedin = new PipedInputStream(pipedout); dataout = new DataOutputStream(pipedout); - engine = Mockito.mock(SFTPEngine.class); - subsystem = Mockito.mock(Subsystem.class); + SFTPEngine engine = Mockito.mock(SFTPEngine.class); + Subsystem subsystem = Mockito.mock(Subsystem.class); Mockito.when(engine.getLoggerFactory()).thenReturn(LoggerFactory.DEFAULT); Mockito.when(engine.getSubsystem()).thenReturn(subsystem); Mockito.when(subsystem.getInputStream()).thenReturn(pipedin);