diff --git a/src/main/java/net/schmizz/sshj/common/Buffer.java b/src/main/java/net/schmizz/sshj/common/Buffer.java index d97cf636..183de8d3 100644 --- a/src/main/java/net/schmizz/sshj/common/Buffer.java +++ b/src/main/java/net/schmizz/sshj/common/Buffer.java @@ -132,8 +132,9 @@ public class Buffer> { protected void ensureAvailable(int a) throws BufferException { - if (available() < a) + if (available() < a) { throw new BufferException("Underflow"); + } } public void ensureCapacity(int capacity) { @@ -392,8 +393,9 @@ public class Buffer> { public String readString(Charset cs) throws BufferException { int len = readUInt32AsInt(); - if (len < 0 || len > 32768) + if (len < 0 || len > 32768) { throw new BufferException("Bad item length: " + len); + } ensureAvailable(len); String s = new String(data, rpos, len, cs); rpos += len; diff --git a/src/main/java/net/schmizz/sshj/common/IOUtils.java b/src/main/java/net/schmizz/sshj/common/IOUtils.java index 72963ad8..8c39bf91 100644 --- a/src/main/java/net/schmizz/sshj/common/IOUtils.java +++ b/src/main/java/net/schmizz/sshj/common/IOUtils.java @@ -40,7 +40,7 @@ public class IOUtils { if (c != null) c.close(); } catch (IOException logged) { - loggerFactory.getLogger(IOUtils.class).warn("Error closing {} - {}", c, logged); + loggerFactory.getLogger(IOUtils.class).warn("Error closing {} - {}", c, logged); } } }